I'm a too big Autotools noob to really give valueable feedback.

Apart from that, this generally looks good to me and it removes old code! I cannot judge whether `autoreconf` does all the things the many manual steps did before. But I guess @b4n might know and/or we will notice during testing and using. Oh, and we use `autoreconf` already in G-P.

I tested the code on my Windows cross-build setup and noticed `autopoint` needs to be installed to run `./autogen.sh`. Maybe we should check for this dependency? And maybe also add `set -e` to the script as it continues even if some of the commands failed: ``` Processing configure.ac autoreconf: Entering directory `.' autoreconf: running: autopoint --force Can't exec "autopoint": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 345. autoreconf: failed to run autopoint: No such file or directory autoreconf: autopoint is needed because this package uses Gettext Done. configure skipped. ```

After installing `autopoint`, setup works. But the build fails: ``` Making all in po make[2]: Entering directory '/build/geany-build/po' make[2]: Leaving directory '/build/geany-build/po' make[2]: *** No rule to make target 'Makevars', needed by 'Makefile'. Stop. make[1]: Leaving directory '/build/geany-build' make[1]: *** [Makefile:589: all-recursive] Error 1 make: *** [Makefile:473: all] Error 2 ```

What's missing: - docs: we have a couple of occurrences of `intltool` (Readme, plugins docs, ...), `git grep` and then search+replace - Travis: we should remove intltool from the CI dependencies and add autopoint

P.S.: there was no CI job for this PR because probably me broke the Travis Github integration last week, without purpose. I tried to re-establish the integration again but I'm not completely sure it worked. We'll see with the next push.

@kugel- what about the remaining issues I noticed?

LGTM now!

@kugel- pushed 1 commit.

c555c72708708f2257424dbb8dcc255f96668047 fix ci

@eht16 any idea about the mingw build failure? I cannot reproduce it on my system. `./scripts/cross-build-mingw.sh` runs fine for me.

According to https://www.linuxquestions.org/questions/slackware-14/undefined-reference-to... (just searched for the error as it was also not obvious to me), adding `-liconv` to CFLAGS fixes the error. However, I don't know what's going on behind the scenes and why it works without for the Linux builds.

Another question: is it on purpose that all the `po/*.po` files are updated?

@kugel- pushed 1 commit.

78f00400618096ce7ae2d8d20e3f56f3d5dc7b8d hopefully fix mingw

Another question: is it on purpose that all the po/*.po files are updated?

No. I reverted that part.

Merging since @eht16 approved it earlier and it blocks the meson PR.