* Make platform agnostic * Fix infinite loop * Update documentation
Resolves #1230. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1236
-- Commit Summary --
* GeanyLua: Fix geany.keygrab
-- File Changes --
M geanylua/docs/geanylua-ref.html (57) M geanylua/glspi_app.c (188)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1236.patch https://github.com/geany/geany-plugins/pull/1236.diff
@xiota pushed 1 commit.
3c2e16a9d5834b1f153a2557ac819386481a9c2e Use g_signal_handler_disconnect instead of g_clear_signal_handler
Thubms up for having a look at this! I didn't have a detailed look at the code but I shamelessly stole the patch and applied during the macOS binary build here
https://github.com/geany/geany-osx/blob/master/geany_patches/08-geany_plugin...
and this function seems to work as advertised.
I just marked this PR with the 2.0 milestone as it's needed on macOS which doesn't have X11. From my point of view this PR can be merged.
Since Geanylua is orphaned if it works for you might as well merge it, can't be any worse.
Merged #1236 into master.
github-comments@lists.geany.org