[geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

List overview All Threads

newer

older

[geany/geany] SaveActions: Ignore...

[geany/geany] Add filter for...

xiota

4 Mar 2023 4 Mar '23

9:34 p.m.

Resolves #1229. You can view, comment on, or merge this pull request online at:

https://github.com/geany/geany-plugins/pull/1234

-- Commit Summary --

* GeanyLua: Fix geany.activate()

-- File Changes --

M geanylua/docs/geanylua-ref.html (2) M geanylua/glspi_doc.c (66)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1234.patch https://github.com/geany/geany-plugins/pull/1234.diff

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1234@github.com>

Attachments:

attachment.html (text/html — 3.1 KB)

Show replies by date

elextr

5 Mar 5 Mar

2:18 a.m.

LGBI and :+1: for fixing the doc.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-1454948269 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c1454948269@github.com

Skif-off

29 Sep 29 Sep

1:32 p.m.

Forgive my curiosity :) Why not ```c if (tab_idx >= 0) { if (tab_idx != gtk_notebook_get_current_page(NOTEBOOK)) { gtk_notebook_set_current_page(NOTEBOOK, tab_idx); } } ``` ?

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2381321216 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2381321216@github.com

xiota

8:57 p.m.

I haven't looked at this in a while. Behavior originally intended is to "Actvate and focus" a document. The original inner conditional `if (idx != ...)` prevented both. Also, `gtk_notebook_set_current_page` most likely already performs necessary checks, so additional checks wastes processor cycles to produce incorrect behavior.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2381492560 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2381492560@github.com

xiota

13 Oct 13 Oct

9:50 a.m.

@xiota pushed 1 commit.

17fe2b18ed41b959a27b691091dc574f280b4027 GeanyLua: Fix geany.activate()

-- View it on GitHub: https://github.com/geany/geany-plugins/pull/1234/files/db1cafc56e2947d5a3e85... You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/before/db1cafc56e2947d5a3e854cdb7c38dac3fd9a178/after/17fe2b18ed41b959a27b691091dc574f280b4027@github.com

xiota

9:57 a.m.

Confirmed original issue described in #1229 and this PR fixes it. Used `list-open-files.lua` to test.

Force pushed to rebase. Also corrected `> 0` to `>= 0`. I had misunderstood @Skif-off's previous comment.

@b4n Should be ready for review and merge.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2408871053 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2408871053@github.com

Skif-off

24 Oct 24 Oct

5:57 p.m.

Any news? In fact, the plugin is broken, because one of its functions is not working (maybe this is not the main function, but then what is the main function? :))).

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2435675472 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2435675472@github.com

xiota

8:16 p.m.

...

the plugin is broken, because one of its functions is not working

Anything that needs changes to this PR?

...

Any news?

I'm waiting for someone to review and commit. Maybe @frlan or @elextr ?

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436052611 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2436052611@github.com

Skif-off

9:14 p.m.

@xiota I meant `geany.activate()`, this function is still broken in upstream.

...

I'm waiting for someone to review and commit.

Yes, I understand, I just thought that an extra reminder in notifications would remind contributors once again about the unresolved issue. And I hope I wasn't too annoying :))

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436157912 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2436157912@github.com

xiota

9:32 p.m.

@Skif-off No problem. Might help to have additional confirmation that this PR is working as expected. You've tested it after the rebase?

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436189761 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2436189761@github.com

Skif-off

11:18 p.m.

...

You've tested it after the rebase?

Hmm... I thought you tested it. Joke :)) I am not a contributor, so my voice has little weight, but just in case I compiled and tested it 20 minutes ago: works fime, I didn't find any problems.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436354304 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2436354304@github.com

xiota

25 Oct 25 Oct

5:19 a.m.

...

my voice has little weight ... I didn't find any problems.

Thanks for testing. Helpful for you to have checked in case I miss something else.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436725306 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2436725306@github.com

Skif-off

12 Dec 12 Dec

9:26 a.m.

@b4n, can you add this to the [2.1.0](https://github.com/geany/geany-plugins/milestone/17) milestone?

I do not know when the new version of Geany is scheduled to be released, there is no alternative solution and it will be sad if all forget about this PR... :)

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2538170669 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2538170669@github.com

xiota

19 Jan 19 Jan

9:32 p.m.

@frlan Any chance you could take a look and merge? This fixes a bug that has been affecting at least a couple users. Thanks.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2601011436 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1234/c2601011436@github.com

Age (days ago)

689

Last active (days ago)

github-comments@lists.geany.org

13 comments

3 participants

tags (0)

participants (3)

elextr
Skif-off
xiota