Extends [#1233](https://github.com/geany/geany-plugins/pull/1233) to add support for Lua 5.1 and LuaJIT by adding compatibility functions/defines. The build script is fixed to not ignore the `--with-lua-pkg` option and to recognize Lua variants: lua, lua53, lua54, lua52, luajit, lua51 (currently in this order). Systems that use a different basename will have to explicitly specify the name, eg lua5.1 or lua-5.1, during configure. To change variants, reconfigure and rebuild. ``` ./configure --with-lua-pkg=[lua] make -C geanylua clean make -C geanylua ```
Supercedes #1231, #1233, #1235. Resolves #1228, #1133. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1238
-- Commit Summary --
* GeanyLua: Use luaL_Reg instead of luaL_reg * GeanyLua: Don't ignore with-lua-pkg configure option * GeanyLua: Add support for Lua 5.2+ * GeanyLua: Add compatibility for Lua 5.1 and LuaJIT
-- File Changes --
M build/geanylua.m4 (28) M geanylua/Makefile.am (2) M geanylua/glspi.h (2) M geanylua/glspi_app.c (4) A geanylua/glspi_compat.c (55) A geanylua/glspi_compat.h (28) M geanylua/glspi_dlg.c (6) M geanylua/glspi_doc.c (4) M geanylua/glspi_init.c (4) M geanylua/glspi_kfile.c (10) M geanylua/glspi_run.c (30) M geanylua/glspi_sci.c (6) M geanylua/gsdlg_lua.c (11)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1238.patch https://github.com/geany/geany-plugins/pull/1238.diff
@xiota pushed 1 commit.
eb2888b6a4d6bd0323c31b16940c2b73febe3940 GeanyLua: Change order of lua package search
@xiota pushed 2 commits.
a60783b5ea29d9765d01e3d3160979d400d08694 Revert "GeanyLua: Change order of lua package search" ca56d831e52a8dd25dd729f77347d58205f6864e Update workflow to use Ubuntu 20.04
@xiota pushed 1 commit.
11dbdbee32c5007f073ac0b9a6eae9d248548874 Update workflow to use libwebkit2gtk-4.0-dev
@xiota pushed 2 commits.
284085ab12815064d48b1a078d7c26af7e35893c Revert "Update workflow to use libwebkit2gtk-4.0-dev" f35cc080cf4bbc87335198304172403525a77ee3 Update workflow to update markdown/webhelper to libwebkit2gtk-4.0-dev
@xiota pushed 1 commit.
76dc5277a4688a30210d6587164e805ca96074d6 Remove multiterm plugin
I'm not sure we should do that. If the decision is to use LuaJIT with a Lua 5.1 fallback, we should support just these versions. Supporting tons of lua versions each with slight language modifications could really become hard to maintain. I don't think anyone of us will have time to test the plugin against all of the lua libraries. Similarly, if we decide to switch to say Lua 5.4, we should stop supporting other Lua versions.
Plus I think you accidentally pushed about all the changes in geany-plugins you've been playing with ;-)
@techee In fact, there are few changes (I don't understand why changes not related to GeanyLua are lumped together) and these versions of Lua will no longer be different. So theoretically, support will not be required for a long time.
@xiota pushed 4 commits.
73f8ff294f5130892f9637d848e199f235b15354 GeanyLua: Use luaL_Reg instead of luaL_reg e99bc00050722d343e9419e68adf39421657d22d GeanyLua: Don't ignore with-lua-pkg configure option 53cc8414a2227eb9ca1d2e840a90d3d52e671e52 GeanyLua: Add support for Lua 5.2+ d2a8537f474bfc63707dd4030d2e5779c02280d7 GeanyLua: Add compatibility for Lua 5.1 and LuaJIT
Rebased on master.
github-comments@lists.geany.org