Added a preferences dialog that allows the highlight colors and overall color alpha to be changed.
* Settings are kept in a .conf file * Tested on linux mint 19.1 cinnamon, geany 1.35 with gtk2 v2.24 and gtk3 v3.22 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/940
-- Commit Summary --
* Added a preferences dialog that allows the highlight colors and
-- File Changes --
M build/pairtaghighlighter.m4 (1) M pairtaghighlighter/Makefile.am (2) A pairtaghighlighter/data/Makefile.am (4) A pairtaghighlighter/data/prefs.ui (225) M pairtaghighlighter/src/pair_tag_highlighter.c (413)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/940.patch https://github.com/geany/geany-plugins/pull/940.diff
Afraid the CI fail is pair tag highligher.
Also probably good to follow the style of the original code eg `f()` not `f ()` but this being a plugin its up to the maintainer to enforce (or not :).
`strtol()` requires including `stdlib.h`, but you could also use one of the GDK functions such as [`gdk_rgba_parse()`](https://developer.gnome.org/gdk3/stable/gdk3-RGBA-Colors.html#gdk-rgba-parse) to parse the colour string or expose [one of the functions](https://github.com/geany/geany/blob/5cc69b3d6728a714637caabf0238759363e91e85...) already in Geany to the plugin API and use that.
@PatrickGMM pushed 1 commit.
4b59b21a4c147f3be0acac3ee31567a822718fbd Fix missing #include <stdlib.h>, remove spaces before '(' in function calls
@PatrickGMM pushed 1 commit.
6337abce101a033355a22fa18da24de1d2352433 Fix pot file error
I see this is pending fixes. Can someone let me know what fixes I need to perform?
@PatrickGMM as a minimum the PR has conflicts and is not mergable as is, not sure what other fixes, but I guess the plugin maintainer should comment too.
@PatrickGMM pushed 86 commits.
d2f2a050b70d13ea2863b02ee95c5487bc2daf0b jump to matching tag and select matching tag e3d7f37ecb5bf394f329b7f94ff86aabac45ba32 jump on 0 line if not selecting 59c678a2c83e5df375f37cb54d62258e9a4ad701 projectorganizer: Make showing empty directories in the sidebar configurable e2e854b6e10b2008ba1166d954502ac23e327b98 projectorganizer: don't use stock icons f01e071c46b51c3805487191f4c2e9688a807626 projectorganizer: use better icons 60fd0d8c75fcd9594af8290b50443f05721ed623 Merge pull request #932 from techee/projorg_icons 48342cf02875ceb6670d530f54bdd7cf2e96df0d Merge pull request #926 from sagarchalise/pt-utils 3d0c513d57f5de8bf568dd642e330a746439759f cppcheck: Set Geany include path for it to find header files 10a26171e92c525f567fe0e8902f1e2779acdcb5 Define PKG_CHECK_VAR for old pkg-config (<= 0.28) e07cba1e1a8b13ab70afe69bd4b0d55a5aa3a60a Define AS_VAR_COPY for old Autoconf 1f8bb80fff647fb031211f3bf1f470304a3c2c14 Merge pull request #947 from b4n/cppcheck-include f615e672e852861a6ecb032a5bced2af04e78f78 latex: added feature: indent line in new environment (fixes #950) 9497d829e1b207eb83575dc6f617feecfb89bc16 Make libgit2 version preprocessor conditionals compatible with libgit2-0.99 faf6ab38b2a4a94512f3d082b6a24618b2c0d9ca Debugger: Update description of dependencies a little f8cf890651190ffe6a6bb8617613b7390c820438 Merge pull request #956 from Doeme/master 2d3d877c8d6facfc3ec0476a43a37939d1475de4 Merge pull request #951 from LukeLR/master 31e0f7b080362062565d0e779f219240d876bd16 Merge pull request #929 from techee/prjorg_config 43d42879d60a523de86675f801b82d0cd63f4b8c Keyrecord: Use capital start on configure 0f6095e925038612682fe0b794263041ce9fa6b1 Markdown: fix colors in gtk3 acc0857897e05c8f11302046ab3b4891fb338a9d GeanyVC: Add support for Fossil SCM (fossil-scm.org) 618e5b019f331cca600f5be47bdeee1afee2e63b GeanyVC: Support multiple instances of current File menu 63968ab837a82e913878ebafbd070f6c9e30f284 Windows installer: Update dependencies 1baa1cdf9e11e0fc539c34c314ff568eb71d8d59 Update of Russian translation for the Addons plugin 8ed72a57132cd5c5ef4bddc9ac70697289c89338 "выноску" --> "подсказку" 5bf7e64390b4e7cfd528395507a7c894ba958c3b "при наведение" --> "при наведении" c9e4c59676ad7f8e2821f2672ab6a7815c1a0215 vimode: Correctly ignore unwanted modifiers 88ca170758d1754048c9796618cccfc16b8e464c Merge pull request #969 from nomadbyte/fossil-scm 90974abf8f6f62dc49f718a2f3431b93a918a59d Merge pull request #974 from dmitryunruh/ru_update 6ded9bc2f47c0001b8914262627f3d576ab1f485 GeanyVC: Use geanyvc_la_LIBADD to add libs needed for unittests 0fb3f6c942a33213c0add12f44d09531864ee7bf Merge pull request #977 from nomadbyte/fossil-scm 062865e3b57a3baa882f69e4f3bc291278c200e4 Merge pull request #965 from M-HT/markdown_fix_colors 6e3767b8afef55ee791b382898c7292981c69e67 Add link to how to install, fix some English 70fa28de78b6d34e277a11c1a7f0368284461be5 Update ao_colortip.c 40d0a87ca6c8e315c2bea83cc83096a91d8904ab Update README c2dcfe56f5419a9784d8f1e2cd6840fc65098ab6 Merge pull request #975 from techee/numlock a5d8e376ff0261013583d3ef118bc06667bda6da GeanyVC: Allow to toggle single files with Space and Return keys e98862e76c4c6f112c8199ac205899d0b180d160 Merge pull request #996 from eht16/geanyvc_commit_toggle_via_space faf34a9c58a02d845ba5e1850b38c80a828116dc GeanyVC:(Fossil) When edited file is not in the repo, simply return; no assert needed 7b09bd88907b6d0682281cf52fba3d459f981a5b Merge pull request #1001 from nomadbyte/geanyvc/fossil-scm 07215199196dd1dfe536331804eba88317f19d27 Merge pull request #971 from nomadbyte/geanyvc/fix-filemenu 07e9524b3b046d2e4f911212561c601e248f8217 Make usage of tabs instead of spaces inside file f06c76d078b964095513a1d959c664a75b6ff030 GeanyVC:(Fossil) Limit the width of the history log/timeline output b939708bf7c0aef3b0c8330649c446ac536f0603 Merge pull request #1004 from nomadbyte/geanyvc/fossil-scm c347e3610c0577ba09cd3d6d06239415a04beb7f GeanyVC: Accept maintainership 5630fabcff5e29e0b4bd25e366bf9885c6e6c886 Merge pull request #1006 from nomadbyte/geanyvc/plugin 39a8ada9cdf76d003060f3d502d7a1529b9ddf01 Mail not valid anymore 1587d6d020f8b7ab1f03463f8fb033283dfdc2d9 Merge pull request #987 from DevynCJohnson/patch-4 439c23ef07bc934649639a6eb23a7424e1a15c9f Windows installer: Update dependencies 06a38f453f73098009b98138bf46d7544bbf1121 Update po files for string freeze of 1.37 abf633e26997173f417fc0f1093716a777f7f877 TreeBrowser: Avoid double node clear ce5f41f4716b83704c3b608add2148c70300ee56 Updated Spanish translation 2a5b2663e7e36004e090e826512a4f5bb5386a53 Merge pull request #1016 from lucasvieites/patch-1 9cd01e5cf64d0bf596c2e1ff31345bd70c364ae9 Update Portugese translation 8925be5a831182c421655b6986e59cbb8120085e First draft of NEWS for 1.37 c49314594d8db189d4205d98c8a088267831f081 NEWS: fix typos and styling 7e578271f400713614f0cd244cf952e188b03e56 Small adjustment at NEWS for 1.37 aacd8ef0e20587aed6671634e9e4f644a47b84ce Remove accidentally added file from POTFILES.skip 29951a0e84fbe6ade4ac480ba8b29672b49198a9 Update nl.po 05265222193b73d20dbb25aced16ad7ad94340e7 Merge pull request #1018 from peter-scholtens/patch-1 08828944bde52db48b3f38d5b83d62c04d512d38 Dutch translation was updated 6c1bf58c4f153611bbea9f824b443f35eb0079ed Debugger: Refactor widget packing (#1017) 80f66aaa7b6fb04e50af299090f965aafdf47025 Remove intl_stats.sh e398bcbd57d124ae19e55925a59566dea02a15a1 Remove ChangeLog for po 93a12982d1119f8edfda6cd131ad973d5779e544 Update of German translation 87e0255f4c9b28eb48085c944c526682ec337b2f Set release date 30730ca8c67b1c0bd6de227b145f0bb3b6385ea9 Minor update on NEWS 8a7ffac6bdfd6a221e3be9222697e4cdad040e02 Fix typo 7355ff96cca3f9b05af19acc5e776b5860c7c301 Post-release version bump 0a45b9f07f93786a750d3c1302574b210b0fcf01 Docs: Add link to installation instructions to READMEs c0114b403700f08d80c8e5ffed348ad643c2ef78 Merge pull request #1021 from eht16/pr981_readme_install_instructions 2a8969f0f69ba5dba96298a314004d3adfff6300 PrettyPrinter: Fix declaration of input_buffer 38645599d105e1f7cd94e38d6d36eace8d5d909b Merge pull request #1024 from frlan/enhancement/prettyprinter/compiler-warning b43825ec5f59727bf4b123ef89932b4fe441e3c6 GeanyVC: Show ellipsis in menu items requiring further user input 8bf506f780f8af69c9061bac4a7a80fb16895b2f Merge pull request #1029 from nomadbyte/geanyvc/251-menu-ellipsis 975968fed5d0f688ec7f47e96c04e57294c96198 GeanyVC: Show ellipsis in menu items requiring further user input (po update) 81029890820bb63a3ed3f4ee5bd7490d5e817a4f Windows installer: ignore patch level version when checking for Geany 1046b3a8691e76910a2ff24a14dfcffe3ee1bbf8 Merge pull request #1031 from eht16/windows_installer_ignore_geany_patch_level 0c37bb4add28b1674ff479b5e021ba05a665c591 Merge pull request #1030 from nomadbyte/geanyvc/251-menu-ellipsis ccefe2b63253f1fede0591559696544c3cc4d949 GeanyVC: Correct the displaying of tooltip for the attach to menubar action bc4dc07e4deb694b647977791a23af6776db4644 Merge pull request #1033 from nomadbyte/geanyvc/fix-tooltip b630e21b2b96cc8e9a915ed50bb3794b5e5e025f PO: Add Ukrainian translation e887fa33ec3de1adfc1852c00f64ea2a306ce86c Merge pull request #1046 from nomadbyte/po/uk 9401dd24f859402d45e6bbfb22a4f45dbd1f3502 Merge pull request #1015 from ChrisJAllan/treebrowser-crash ad50d3ed2ddfe11cd07954786b96725602fb4ddd Use stdbool.h istead of redefining bool 7c540bf347d0f0c6f6ab5123fa8f226b2f9152ee Merge pull request #1053 from xyproto/no-redefine-bool 3bc2d8b6d2589d5d5bb27a2c9a115a41498ad7e3 Merge commit '6337abce'
github-comments@lists.geany.org