Supported commands are: za / zo / zc toggle / open / close fold on one level of folding zA / zO / zC toggle / open / close fold on all folding levels zR / zM open / close all folds You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1350
-- Commit Summary --
* Vimode: implement fold in vimode plugin
-- File Changes --
M vimode/README (11) M vimode/src/Makefile.am (4) M vimode/src/cmd-runner.c (10) A vimode/src/cmds/fold.c (130) A vimode/src/cmds/fold.h (37)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1350.patch https://github.com/geany/geany-plugins/pull/1350.diff
Previous pull request #1327
@techee requested changes on this pull request.
Looks good apart from the several documentation-related changes below.
Once fixed, you can squash the result to a single commit. (And be careful about what git does ;-)
@@ -413,6 +413,15 @@ a new command, please do not forget to update the table below.::
cursor [into register x] y ["x]y{motion} yank Nmove text [into register x] yy ["x]yy yank N lines [into register x] + zA zA open a closed fold or close an open fold + recursively + zC zC close folds recursively + zM zM set 'foldlevel' to zero + zO zO open folds recursively + zR zR set 'foldlevel' to the deepest fold + za za open a closed fold, close an open fold + zc zc close a fold + zo zo open fold
Could you move this block to the same place as in index.txt, i.e. under section "2.5 commands starting with z"? And also within this section to the same place as in index.txt? (of course taking into account that some commands are missing)
@@ -96,7 +96,7 @@ This is an incomplete list of known limitations of the plugin:
* named registers and related commands are not implemented * Ctrl+X mode is not implemented * marks are not implemented -* fold commands are not implemented +* most fold commands are not implemented
I'd say "many" would be better as the most important ones are implemented now.
- (at your option) any later version.
+ * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ + +#include "cmds/fold.h" +#include "utils.h" + +/* fold command does not depend on state of parents */
I'd say the comments above this define and the 2 other below is useless now and can be removed.
OK I did it
Merged #1350 into master.
Looks good, merged. Thanks a lot for all your contributions!!!
Thanks
github-comments@lists.geany.org