Based off work from @hyperair that was merged at some point in #677, but reverted since then (see there). This adds a couple bits on top to fix some issues, and I believe the "meh no GTK2" whining of mine is lost to time and the fact there's no supported webkit for GTK2 anymore anyway.
BEWARE: this has been given little testing in the 2020s, I just rebased, merged a couple branches to the point there diffed empty, and did some very basic testing (it builds, it runs, and *seems* to work). Take it, leave it, improve it, comment on it, etc. I'll be there try not to forget looking at this for any comment though :wink:
NOTE: it's not at 100% feature-parity with the old version, mostly because of API changes regarding the inspector (II[RU]C, docking settings are not as controllable anymore), yet the inspector itself has seen countless improvements of course. But again, maybe things have changed since 2018.
See also #1217. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1224
-- Commit Summary --
* webhelper: Initial port to webkit2gtk * webhelper: Initialize webkit favicon database * webhelper: Fix ctrl+scroll zooming in gtk3 * webhelper: Port context menu to WebKitContextMenu * webhelper: Use the right type for GSimpleAction * webhelper: Port link hovering functionality to webkit2gtk * webhelper: Fix constness of a variable * webhelper: Add missing G_CALLBACK() casts * webhelper: Avoid a deprecation * webhelper: Make gtk3-only * webhelper: Remove pre-GTK3 compatibility checks * webhelper: Don't use deprecated GtkStock * webhelper: Port inspector signal handlers to webkit2gtk * webhelper: Fix flip-panes action * webhelper: Remove custom docking position support * webhelper: Fix loading progress display
-- File Changes --
M build/webhelper.m4 (5) M webhelper/src/Makefile.am (3) M webhelper/src/gwh-browser.c (762) M webhelper/src/gwh-browser.h (11) M webhelper/src/gwh-plugin.c (60) M webhelper/src/gwh-settings.c (9)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1224.patch https://github.com/geany/geany-plugins/pull/1224.diff
@b4n pushed 4 commits.
981f9e22be58d5da9a8f27457fc2472a689e5fa8 webhelper: Fix state of the Full-content zoom menu item aa946dbb001a6882a57185028631a4916dabd5e5 webhelper: Fix leaking GActions add6a5c093a35c0d09fed3cbbc94701a4ff19e25 webhelper: Fix internal browser-auto-reload menu item state 81c631fdeffc65f70319be2783d85ee35e255829 webhelper: Improve style
Merged #1224 into master.
github-comments@lists.geany.org