One more warning I overlooked in https://github.com/geany/geany/pull/4228.
clang reports: ``` [202/372] Compiling C object libregex.a.p/ctags_gnu_regex_regex.c.o In file included from ../ctags/gnu_regex/regex.c:63: ../ctags/gnu_regex/regex_internal.c:697:36: warning: variable 'q' set but not used [-Wunused-but-set-variable] 697 | const unsigned char *raw, *p, *q, *end; | ^ ``` You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4232
-- Commit Summary --
* regex: Remove unused variable
-- File Changes --
M ctags/gnu_regex/regex_internal.c (4)
-- Patch Links --
https://github.com/geany/geany/pull/4232.patch https://github.com/geany/geany/pull/4232.diff
@b4n approved this pull request.
I kind of thought glibc developers wouldn't have let that slide without a reason, but unless Darren Hiebert messed with it back in 2009 (which seems unlikely to me), it looks like they did. I can't see a reason why that variable would have any useful side-effect, so that's indeed probably a leftover.
Merged #4232 into master.
github-comments@lists.geany.org