"Editor -> Display" is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing.
Close #3605. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3643
-- Commit Summary --
* Move "Virtual Spaces" preference to "Editor -> Features"
-- File Changes --
M data/geany.glade (171)
-- Patch Links --
https://github.com/geany/geany/pull/3643.patch https://github.com/geany/geany/pull/3643.diff
Looks good - I just tested this PR and it works as described (no way for a human being to review the XML diff itself).
In the future we could introduce some tab like "Behavior" which is so generic-sounding we'd be free to place there just anything :-).
Looks good - I just tested this PR and it works as described (no way for a human being to review the XML diff itself).
Use Git's own diff to see it, and enable highlighting of moved lines. Almost all of it is just moved, minus a few lines holding indices and such (and maybe uselessly setting an active radio button, I don't remember if I left it in there and am on a phone)
In the future we could introduce some tab like "Behavior" which is so generic-sounding we'd be free to place there just anything :-).
Hehe, smart 🤓
In the future we could introduce some tab like "Behavior" which is so generic-sounding we'd be free to place there just anything :-).
What, "General" isn't general enough ;-P
@eht16 commented on this pull request.
<property name="visible">True</property>
+ <property name="can-focus">False</property> + <property name="left-padding">12</property> + <child> + <object class="GtkVBox" id="vbox48"> + <property name="visible">True</property> + <property name="can-focus">False</property> + <child> + <object class="GtkRadioButton" id="radio_virtualspace_disabled"> + <property name="label" translatable="yes">Disabled</property> + <property name="visible">True</property> + <property name="can-focus">True</property> + <property name="receives-default">False</property> + <property name="tooltip-text" translatable="yes">Do not show virtual spaces</property> + <property name="use-underline">True</property> + <property name="active">True</property>
This seems new but probably added by Glade automatically and we set an explicit default value in the code anyway, so it's fine.
@eht16 approved this pull request.
LGTM
Merged #3643 into master.
github-comments@lists.geany.org