The use of `geany_wrap_label_new()` together with the list below seems to interact in a strange way somehow and generate lots of runtime warnings/errors.
This is a (cowardly) attempt by fixing this without having to understand what is going on ;-). Simply using `gtk_label_new()` seems to resolve the issue.
Also, I think the text can be made a bit shorter in case the translation is too wide for some languages. The "at startup" is kind of misleading anyway since plugins are loaded immediately when checked in the box below and since this is a preference, it's remembered so I think it's pretty clear it happens at startup too.
Just a historical note - the text used to be much longer in the past so this is probably why geany_wrap_label_new() was used: https://github.com/geany/geany/commit/b0cd7b918bb0c53c8f2a5173027dc3087019a3...
Fixes #2065. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4079
-- Commit Summary --
* Fix GTK runtime errors generated by the plugin manager
-- File Changes --
M src/plugins.c (3)
-- Patch Links --
https://github.com/geany/geany/pull/4079.patch https://github.com/geany/geany/pull/4079.diff
@eht16 approved this pull request.
I agree with the change of the label text and that there is probably no need for the wrapped label.
Good catch! Thanks.
Unless there are any objections, I'd merge this in about a week.
@b4n I noticed you assigned yourself to this PR. Knowing you, I assume you want to dive into the depths of GTK and fix `geany_wrap_label_new()` so it works anywhere under any condition. Feel free to do so, but in this case I think the usage of `gtk_label_new()` is a sufficient "ordinary mortal" fix :-)
Merged #4079 into master.
github-comments@lists.geany.org