Show `send_cmd_prefix` and `send_selection_unsafe` VTE preferences in the Various preferences page instead of having them totally hidden.
I didn't add `emulation` setting to the various prefs because it's likely we'll need to drop it soon because [libvte dropped support for it](https://github.com/geany/geany/issues/336#issuecomment-56833416), but if we want we can now easily add it. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/651
-- Commit Summary --
* vte: Show some hidden preferences in the Various preferences page
-- File Changes --
M src/keyfile.c (37)
-- Patch Links --
https://github.com/geany/geany/pull/651.patch https://github.com/geany/geany/pull/651.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651
@@ -745,9 +740,6 @@ static void load_dialog_prefs(GKeyFile *config) g_key_file_set_boolean(config, "search", "pref_search_hide_find_dialog", suppress_search_dialogs); }
- /* read stash prefs */
- settings_action(config, SETTING_READ);
I had to move this down so the Stash group I add later in this function gets loaded without additional calls.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651/files#r39161890
@@ -940,12 +939,6 @@ static void load_dialog_prefs(GKeyFile *config)
tool_prefs.context_action_cmd = utils_get_setting_string(config, PACKAGE, "context_action_cmd", "");
- /* build menu */
- build_set_group_count(GEANY_GBG_FT, build_menu_prefs.number_ft_menu_items);
- build_set_group_count(GEANY_GBG_NON_FT, build_menu_prefs.number_non_ft_menu_items);
- build_set_group_count(GEANY_GBG_EXEC, build_menu_prefs.number_exec_menu_items);
moved down as it depends on stash prefs being loaded
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651/files#r39161985
If I read the [codocumentation](https://github.com/geany/geany/blob/master/src/vte.c#L756) right the `send_cmd_prefix` actually only affects the `cd` commands, not all commands run in VTE, maybe its name should be changed to reflect that now its made more visible.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651#issuecomment-139245513
@elextr indeed, it's (currently) only used for `cd`, but it's also the only command we currently inject AFAIK.
If really you want another name, we'd need 1) compat code for it, and 2) such a name :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651#issuecomment-139317811
(BTW, I have a patch to show the section name in the Various tab's tree, so it's more obvious it to what it relates, which becomes useful if we keep adding new ones)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651#issuecomment-139318107
On 11 September 2015 at 03:27, Colomban Wendling notifications@github.com wrote:
@elextr https://github.com/elextr indeed, it's (currently) only used for cd, but it's also the only command we currently inject AFAIK.
What I was referring to is that it is not used on the execute command, and probably isn't wanted there.
If really you want another name, we'd need 1) compat code for it, and 2) such a name :)
— Reply to this email directly or view it on GitHub https://github.com/geany/geany/pull/651#issuecomment-139317811.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651#issuecomment-139407708
@b4n is this all the remaining hidden but not various prefs or are there more?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651#issuecomment-139415247
On 11 September 2015 at 10:05, Matthew Brush notifications@github.com wrote:
@b4n https://github.com/b4n is this all the remaining hidden but not various prefs or are there more?
Possibly one more, there are 26 things documented and only 24 lines in the various tab.
— Reply to this email directly or view it on GitHub https://github.com/geany/geany/pull/651#issuecomment-139415247.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/651#issuecomment-139430745
@b4n pushed 1 commit.
2150302 VTE: Don't show the various settings when VTE is disabled on the CLI
Merged #651.
github-comments@lists.geany.org