This PR changes the naming convention in the workbench plugin from "folder" to "sub-directory".
@b4n, @elextr: please give some feedback as you two participated in the mail thread about the naming convention for directories and folders. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/678
-- Commit Summary --
* workbench: renamed "folder" to "sub-directory"
-- File Changes --
M workbench/README (8) M workbench/src/popup_menu.c (58) M workbench/src/popup_menu.h (2) M workbench/src/sidebar.c (28) M workbench/src/sidebar.h (4) M workbench/src/wb_project.c (8)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/678.patch https://github.com/geany/geany-plugins/pull/678.diff
LGBI. I didn't check the code part in detail, and I personally would only have changed the user facing parts, not the internal names, but you have done it now, so thats fine.
A couple of minor unrelated fixes to the readme noted.
elextr commented on this pull request.
@@ -85,7 +85,7 @@ These are the available items:
if you right clicked inside of a project. After selecting it a dialog will be opened. Chosse the directory which shall be added. After that
Choose
elextr commented on this pull request.
@@ -101,18 +101,18 @@ These are the available items:
**Directory settings** Select this item to change the directory settings. It is only available if you right clicked inside of a project directory. In the directory - settings you can set a filter which controls the files and folders + settings you can set a filter which controls the files and sub-directories that shall be displayed or not.
More idiomatic to say "will" in this context.
@LarsGit223 pushed 1 commit.
91a000f workbench: fixed typos in README
@elextr: fixed README also, thanks for reporting the typos.
Merged #678.
github-comments@lists.geany.org