- version locally the script `geany-release.py` so far hosted in the wiki - applied fix for building without signing (missing key/certificate in the filesystem) - added copying geany.nsi from the build directory into the root directory so that no need to run configure twice - changed version num to 2.1 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4223
-- Commit Summary --
* version locally the script geany-release.py so far hosted in the wiki + fixes applied for building without signing/missing key/certificate
-- File Changes --
A scripts/geany-release.py (135)
-- Patch Links --
https://github.com/geany/geany/pull/4223.patch https://github.com/geany/geany/pull/4223.diff
@b4n commented on this pull request.
+SOURCE_DIR = join(os.environ['HOME'], 'git', 'geany')
+BUILD_DIR = join(os.environ['HOME'], 'git', 'geany', '_build') +RELEASE_DIR_ORIG = join(BASE_DIR, 'release', 'geany-orig') +RELEASE_DIR = join(BASE_DIR, 'release', 'geany') +BUNDLE_BASE_DIR = join(BASE_DIR, 'bundle') +BUNDLE_GTK = join(BASE_DIR, 'bundle', 'geany-gtk') +GEANY_THEMES_URL = 'https://github.com/geany/geany-themes/archive/refs/heads/master.zip' +GEANY_THEMES_DIR = join(BUNDLE_BASE_DIR, 'geany-themes') +INSTALLER_NAME = join(BASE_DIR, f'geany-{VERSION}_setup.exe') + +# signing params +SIGN_CERTIFICATE = join(BASE_DIR, 'codesign.pem') # adjust to your needs +SIGN_CERTIFICATE_KEY = join(BASE_DIR, 'codesign_key.pem') # adjust to your needs +SIGN_WEBSITE = 'https://www.geany.org' +SIGN_NAME = 'Geany Binary' +SIGN_TIMESTAMP = 'https://zeitstempel.dfn.de/'
After a bit of research this looks probably OK, but without further explanation it looks *so* shady it'd be good to explain it. @eht16 can probably help here(?)
If this file is in the repository, its name should reflect that it's for *Windows* releases, not the usual source releases (which is covered by *doc/making-a-release*).
Makes sense @b4n I will rename to msys2-geany-release.py if that's ok Forgot to mention: the original script from @eht16 is https://wiki.geany.org/_media/howtos/win32/geany-release.py.txt linked from https://wiki.geany.org/howtos/win32/msys2
@giuspen pushed 1 commit.
8959111d480374bdb9cc5e662131c97067ff4ea2 renamed geany-release.py to make it clear it is for windows/msys2
github-comments@lists.geany.org