So as you know the new macOS comes with a new design language. Since @techee so kindly built me an M1 binary, I thought to say thanks by designing a simple new version of the icon that is suited for the new OS versions. Hope you like the designs.
<img width="1002" src="https://user-images.githubusercontent.com/2157285/140661024-3df31d57-b8c0-48...;
<img width="669" src="https://user-images.githubusercontent.com/2157285/140660989-7f77901c-3f45-4c...;
<img width="563" src="https://user-images.githubusercontent.com/2157285/140661000-748a08c8-246f-4f...;
<img width="475" src="https://user-images.githubusercontent.com/2157285/140661031-4904f174-a6b5-42...;
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-osx/pull/33
-- Commit Summary --
* <a href="https://github.com/geany/geany-osx/pull/33/commits/1975506625393f1072703fa4f4f373c8d61a0ac5">A new icon for the macOS Big Sur / Montery design</a>
-- File Changes --
A geany-macos-icon.afdesign (0) M iconbuilder.iconset/icon_128x128.png (0) M iconbuilder.iconset/icon_128x128@2x.png (0) M iconbuilder.iconset/icon_16x16.png (0) M iconbuilder.iconset/icon_16x16@2x.png (0) M iconbuilder.iconset/icon_256x256.png (0) M iconbuilder.iconset/icon_256x256@2x.png (0) M iconbuilder.iconset/icon_32x32.png (0) M iconbuilder.iconset/icon_32x32@2x.png (0) M iconbuilder.iconset/icon_512x512.png (0) M iconbuilder.iconset/icon_512x512@2x.png (0)
-- Patch Links --
https://github.com/geany/geany-osx/pull/33.patch https://github.com/geany/geany-osx/pull/33.diff
Hey, thanks, that's really nice!!!
Maybe just 2 requests: 1. Could you use the Geany icon from here https://github.com/geany/geany/blob/master/icons/scalable/geany.svg as the source? It seems you grabbed the older version of the icon from somewhere but there were some minor tweaks of the icon in the meantime (a little nicer handle of the lamp for instance). 2. Is it possible to export the vector icon to svg instead of the afdesign file and have the svg committed instead? I expect the editor you used will allow you to both export the file as svg and import it too and it's a more universal file format than the proprietary afdesign file.
Once again, thanks a lot, I like the design of the icon a lot!!!
@pouyakary pushed 2 commits.
9a6fcd12397efd7ee4093a0322a186f1f5e81ad4 Added the new icon version and removed the older PNG files b62698e957573d91c9133b0640031a740cfcaca8 Added the new icon builds
You're very welcome! I included the afdesign file since I used the Affinity Designer to make it and though the source material should be available. But yeah! The SVG is now included two. I guess it could be nice to have a repo for the geany's icon. There these files could be included. And this is the new icon with the SVG icon replaced with the older one:
<img width="512" src="https://user-images.githubusercontent.com/2157285/140705908-a26d40e7-48df-4561-8d11-f92e1b061fd8.png">
Yet I guess the source SVG needs a little bit of tweak in some places. For example:
<img width="187" src="https://user-images.githubusercontent.com/2157285/140706355-02581efa-5bce-46de-a446-2989f1f8a819.png">
I don't know if it is intentional or the SVG is broken on bigger size.
Also now that I'm playing with the icon, I think it'll be good to have a little bit of shadow/gradient to match other mac icons:
<img width="512" alt="geany-macos-icon" src="https://user-images.githubusercontent.com/2157285/140708240-e878246c-117a-407b-a97a-d00500a39b7b.png">
The new version vs the previous one:
<img width="438" alt="Screen Shot 1400-08-17 at 11 55 25" src="https://user-images.githubusercontent.com/2157285/140708163-91af1811-7be4-455f-bb5e-6ebf0ec25bb0.png">
@pouyakary pushed 1 commit.
e99a739adaeb479295c59efdb0e1d91229292f0e The new background for the icon
@pouyakary pushed 1 commit.
97a7129304c466b6b6eb2733f1d1db41751ebd08 Added the proper SVG file and some shadow to the icon
Okay so I found the problem with my SVG file and fixed it. So the SVG problems are gone. And also with a little bit of shadow to make it look 3D in the mac format:
<img width="457" alt="Screen Shot 1400-08-17 at 12 11 44" src="https://user-images.githubusercontent.com/2157285/140710433-385b1129-771e-4de0-8bb0-ab7bd67347e8.png">
<img width="512" alt="geany-macos-icon" src="https://user-images.githubusercontent.com/2157285/140710566-67a9ce78-a240-43c5-a16e-b01ef685ef78.png">
Nice, thanks!
Maybe a few nitpicky comments (while there's a guy around that's willing to do the graphical stuff I personally hate doing ;-): 1. I'm not sure if the last version of the icon isn't "overshadowed" - I think I like the version where the shadow is just below the lamp better. I think such deep shadow like the shadow behind the handle and the genie isn't typical for macOS icons - if you want to keep some shadow there, maybe you could do something like in the Calculator app or Home app in macOS where the shadow is quite small and just helps the icon rise above the surface. I like the shadow and the gold glow at the bottom though - the bottom part of the icon would be much more empty without it. 2. The top part of the middle ruby seems to be cut off in the latest version of the icon - this glitch doesn't seem to be present in the Geany's original svg icon. 3. Is there anything essential in the committed afdesign file? Couldn't there just be the svg file as the only source? Would some essential information be lost by this so the icon couldn't be modified if some change was needed in the future just from the svg? Basically I'd like to avoid to be bound to any non-opensource tool for editing.
1. The steam of Geany is something that if you try to fit in the box makes it very small, makes the icon very bad, and since overflow is something nice in the mac apps, I thought maybe it is nice to have it there: <br><br> <img src="https://user-images.githubusercontent.com/2157285/141271542-b9b4ded3-e720-477d-b9d1-7666c1ab7ab5.png"><br><br> Now, not having the shadow makes it really hard for the eye to catch it in the small size:<br><br><img width="482" src="https://user-images.githubusercontent.com/2157285/141271222-053e4a88-e845-49b8-8771-0ebf2a52ecea.png"> <br><br> I can make the shadow like this:<br><br><img width="608" alt="Screen Shot 1400-08-20 at 12 51 02" src="https://user-images.githubusercontent.com/2157285/141272045-8e347b21-38f7-457e-8519-eb5a59f1a847.png"><br><br> But it still becomes a little bit hard to catch by the eye:<br><br><img width="269" src="https://user-images.githubusercontent.com/2157285/141272357-931f7559-8966-4e71-99d1-723d33d8ef73.png">
2. Yeah for some reason I don't know why that happens :/ any editor that I open crashes the middle gem, it happens when you zoom into the SVG and when you don't it seems fine, I think I have to redesign it but it seems like a hard object to modify so I have to see if I can do it <br><br> <img width="113" alt="Screen Shot 1400-08-20 at 12 55 15" src="https://user-images.githubusercontent.com/2157285/141272784-fef505e3-6af2-43d6-929f-6eb5a23c593d.png">
3. Yeah unfortunately :( SVG cannot store shadows and so when you export SVG, it only encodes the PNG shadow into a base64 data in the SVG, something you cannot edit. I don't know any open source vector editor on the mac. If I knew I would, but currently I only know of a few editors and Affinity Designer is the one that I had so...
P.S. Geany is your software, it doesn't matter if it is overshadowed or not, you should like it :)
The steam of Geany is something that if you try to fit in the box makes it very small, makes the icon very bad, and since overflow is something nice in the mac apps, I thought maybe it is nice to have it there:
Totally agree, the genie "escaping" the square is really cool.
I can make the shadow like this:
I think that's too little shadow. Basically I just thought to have the shadow closer to the genie and the handle (and the shadow could even be a bit darker if needed). It could be reduced to about a half and end at the place of the red dot below (instead of the blue one where it ends now).
<img width="512" alt="aaa" src="https://user-images.githubusercontent.com/713965/141359838-69a9ff49-2ee2-4ef1-9f53-7819538f04ac.png">
Yeah for some reason I don't know why that happens :/ any editor that I open crashes the middle gem, it happens when you zoom into the SVG and when you don't it seems fine, I think I have to redesign it but it seems like a hard object to modify so I have to see if I can do it
I tried to open it in Sketch (which is the only vector editor I have) and it seemed fine there. Anyway, would be nice if you could find some workaround for the export at least (e.g. adding a triangle of the same color to the top).
Yeah unfortunately :( SVG cannot store shadows and so when you export SVG, it only encodes the PNG shadow into a base64 data in the SVG, something you cannot edit. I don't know any open source vector editor on the mac. If I knew I would, but currently I only know of a few editors and Affinity Designer is the one that I had so...
I understand. There's linux Inkscape but its macOS port is quite terrible (just tried to install it and it doesn't seem to respond to mouse clicks). The original Geany icon was created in Inkscape I believe but Inkscape also uses svg only as its format. I guess we'll have to live with the afdesign file.
P.S. Geany is your software, it doesn't matter if it is overshadowed or not, it's you who should like it :)
Nah, it's everyone's editor, and it's not that I dislike any of your designs (in fact the opposite), I'm just sure it won't be touched by anyone for the rest of eternity so better to misuse the guy who's willing to do the work as much as possible now ;-).
@pouyakary pushed 1 commit.
221121414138e8413a507aa662caeeec528eb148 moved the shadow a little bit and fixed the middle gem
Okay I really liked your idea on the half size shadow, it really become awesome:
<img width="821" src="https://user-images.githubusercontent.com/2157285/141388551-4d5fd5df-3569-431a-93db-49ab173a2db1.png">
<img width="447" src="https://user-images.githubusercontent.com/2157285/141388265-68c59b60-1f35-4c3c-af1d-86fde0539ffd.png">
<br>
I understand. There's linux Inkscape but its macOS port is quite terrible (just tried to install it and it doesn't seem to respond to mouse clicks). The original Geany icon was created in Inkscape I believe but Inkscape also uses svg only as its format. I guess we'll have to live with the afdesign file.
I tried the latest version of Inkscape, will they've managed to make it actually run it on mac after quite long years (it still crashed more than 20 times, but at least it opened and buttons clicked), it seems that SVG is still not capable of having shadows like the ones mac needs for the background. If I ever saw a good quality vector editor capable of that much shadow generations, I will def migrate it there.
And I still think it would be nice to have a separate repo just for the icon designs.
<br>
Nah, it's everyone's editor, and it's not that I dislike any of your designs (in fact the opposite), I'm just sure it won't be touched by anyone for the rest of eternity so better to misuse the guy who's willing to do the work as much as possible now ;-).
Geany was one of the very first editors I had, and I even kept it when I didn't needed it for its beautiful icon :) And then many years passes and I contribute to who knows how many projects but then I come back to Geany and get a chance to literally change "that" icon and you say the change will last an eternity, It just ironically feels so surreal. I guess somethings just never become normal you know — I think if I ever open up Geany and see the icon there, I will feel so proud :)
Okay I really liked your idea on the half size shadow, it really become awesome:
Looks perfect to me!
As I think we're done design-wise, could you please modify this pull request so there's just a single commit containing all the changes? I also think that the png inside `macos-icon-design` is unnecessary (can be easily created from the svg by anyone) and doesn't have to be committed.
And I still think it would be nice to have a separate repo just for the icon designs.
Possibly, but `geany-osx` is already a mix of so much different stuff (scripts, package definitions, patches, gtk icon theme, gtk theme, etc.) that one more thing inside isn't a problem I think.
Geany was one of the very first editors I had, and I even kept it when I didn't needed it for its beautiful icon :) And then many years passes and I contribute to who knows how many projects but then I come back to Geany and get a chance to literally change "that" icon and you say the change will last an eternity, It just ironically feels so surreal. I guess somethings just never become normal you know — I think if I ever open up Geany and see the icon there, I will feel so proud :)
Enjoy this feeling. In my experience it lasts for just about one afternoon ;-). You'll just get used to your new self for which it's a normal thing it created this icon.
@pouyakary pushed 1 commit.
a70e7ab8c8b6a617c6cb07ee0b76ca68942d16a0 no more png
Enjoy this feeling. In my experience it lasts for just about one afternoon ;-). You'll just get used to your new self for which it's a normal thing it created this icon.
Sure do :)
As I think we're done design-wise, could you please modify this pull request so there's just a single commit containing all the changes? I also think that the png inside macos-icon-design is unnecessary (can be easily created from the svg by anyone) and doesn't have to be committed.
I've had some trouble squashing the commits into one. GitHub itself does have a squash and merge button can you please use that?
Merged #33 into master.
Done. Once again, thanks for your contribution!
And you're very welcome!
@pouyakary Since we are discussing licensing of the themes, what's the license of the icon you have contributed? `geany-osx` is a collection of stuff for the macOS build consisting of various licenses so it's really up to you.
@techee hi Jiří! Thanks a lot for asking. I don't see this icon as my contribution but I see my contribution as a patch to the someone else's work. I think they should be choosing, but if that is not the case, it would be my honor for the Geany team to have all copyrights, so let's make it MIT/X: (thanks a lot for asking BTW!)
Copyright (C) 2021 Pouya Kary kary@gnu.org
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE X CONSORTIUM BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Except as contained in this notice, the name of Pouya Kary shall not be used in advertising or otherwise to promote the sale, use or other dealings in this Software without prior written authorization from Pouya Kary kary@gnu.org.
hi Jiří! Thanks a lot for asking. I don't see this icon as my contribution but I see my contribution as a patch to the someone else's work. I think they should be choosing...
Thanks, that's in fact a good point, it should probably be considered to be a modification of the existing icon which I think is GPLv2 or later like the rest of the Geany code. So I'd keep it that way and mention it in COPYING.
Any thoughts on https://github.com/geany/geany-themes/pull/43#issuecomment-2488926364 ?
github-comments@lists.geany.org