You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/774
-- Commit Summary --
* Simplify and cleanup encoding menu building * Simplify encoding menu creation loop
-- File Changes --
M src/encodings.c (126)
-- Patch Links --
https://github.com/geany/geany/pull/774.patch https://github.com/geany/geany/pull/774.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/774
Not tested, but LGTM at a glance.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/774#issuecomment-159773793
while (order < group_size) /* the biggest group has 13 elements */
/** TODO can it be optimized? ATM 882 runs at line "if (encoding->group ...)" */
Is this comment still relevant, and if so which "if" does it refer to? AFAICT there is no `if(encoding->group` line in the following loop.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/774/files#r45967569
while (order < group_size) /* the biggest group has 13 elements */
/** TODO can it be optimized? ATM 882 runs at line "if (encoding->group ...)" */
well, it's still not great so maybe. And yeah, fixed the reference that I changed at some point but changed it back later.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/774/files#r46071637
@codebrainz fair enough, I used shiny C99 for loop declarations all through this function :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/774#issuecomment-160218783
Merged #774.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/774#event-476638667
github-comments@lists.geany.org