Supersedes #1223 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1235
-- Commit Summary --
* Emit project-close before destroying project
-- File Changes --
M doc/pluginsignals.c (5) M src/plugindata.h (2) M src/project.c (4)
-- Patch Links --
https://github.com/geany/geany/pull/1235.patch https://github.com/geany/geany/pull/1235.diff
Hum, didn't I comment on this?
Looks mostly good, but for the part where a plugin might want to react to that signal to restore the non-project values, in which case Geany still behaving like a project is open might be problematic. I don't think plugins from GP would currently suffer from that, but show knows. For example Project Organizer checks for the Geany project there, but fortunately it also check for its internal project pointer which is reset to NULL just before, but it's close to affect it.
So maybe we should have a `project-before-close` signal instead, although it ain't so pretty.
Ah OK I commented on the other PR, #1223.
I'm closing this in favor of #1223 that while a little less pretty is safer (and we already have *before* variants of some signals)
Closed #1235.
github-comments@lists.geany.org