Purpose: * do not show info bar asking about reloading if file hasn't changed.
I have copied the logic from `document_reload_prompt`, however I am not sure about the following: * would the same logic apply? (I did a copy/paste) * is it safe to ignore the result of `document_reload_force`? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1463
-- Commit Summary --
* Do not show reload info bar if file hasn't changed
-- File Changes --
M src/document.c (32)
-- Patch Links --
https://github.com/geany/geany/pull/1463.patch https://github.com/geany/geany/pull/1463.diff
The info bar is saying that the file on disk may have changed, not that the buffer has changed.
So the fact that the buffer has an edit history or is unchanged is irrelevant to the message.
What were you trying to achieve?
@elextr steps to reproduce: 1. open a file 2. edit the file externally (e.g. with nano) 3. an info bar is displayed, asking to reload the file
My ideal situation: 1. open a file 2. edit the file externally (e.g. with nano) 3. file is reloaded without UI interaction if the buffer did not change
I can see the "loss of feature" in the sense that user is not made aware of such reload happening, but I was under the impression that would not be a problem?
file is reloaded without UI interaction if the buffer did not change
see #1246
I can see the "loss of feature" in the sense that user is not made aware of such reload happening, but I was under the impression that would not be a problem?
As you will se from the comments on #1246 such a feature is not acceptable without an option to turn it off.
#1246 covers this already, closing
Closed #1463.
github-comments@lists.geany.org