Apart from fixing a load of deprecation warnings on gtk3 this also fixes two gtk3 related problems in the treebrowser plugin: - lines in the Treeview had a red color - now they are black like under gtk2 - the text field turned red if the path entered wasn't a valid directory - this did not work under gtk3 before but now it works
The gtk2 behavior is unchanged and there are also no functional changes.
If this get's merged PR #279 would become needless and could be closed un-merged. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/864
-- Commit Summary --
* treebrowser: fixed deprecated gtk calls for gtk3
-- File Changes --
M build/treebrowser.m4 (2) M treebrowser/src/Makefile.am (6) M treebrowser/src/treebrowser.c (237)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/864.patch https://github.com/geany/geany-plugins/pull/864.diff
@medovina What do you think about it?
Apologies for the delay in responding - the last few weeks have been super busy.
I tried building with these changes. It's nice to see that all the build warnings are gone!
On my machine (running Ubuntu 19.04), without your changes lines in the TreeView are gray, not red. With your changes, they are black. I personally think the gray looks better - the black lines are too distracting.
What operating system / distribution are you running? That could have an effect on the TreeView line colors. If possible, I think it would be better to use a color from the underlying GTK theme rather than hard-coding black.
Apologies for the delay in responding - the last few weeks have been super busy.
Never mind - we are all volunteers.
What operating system / distribution are you running? That could have an effect on the TreeView line colors. If possible, I think it would be better to use a color from the underlying GTK theme rather than hard-coding black.
I am using Ubuntu 18.04.2 and a gnome desktop. I lately implemented the option to show tree lines for the workbench plugin's sidebar and there I also see red lines. So most likely you are right - it seems to be a local problem not a general one. I will remove the CSS part which sets the border color.
Done. The tree-line color (border-color) is now not explicitly set (so it is red again on my system).
OK - I built with your latest changes. They look fine to me.
Do you know why the Travis bulid above failed? That might be worth investigating.
There seemed to be a problem with devhelp on the gtk3 build only: ``` echo "#include "dh-marshal.h"" > dh-marshal.c && \ /usr/bin/glib-genmarshal ../../../devhelp/devhelp/dh-marshal.list --body --prefix=_dh_marshal dh-marshal.list >> dh-marshal.c (process:18603): GLib-Genmarshal-WARNING **: failed to open "dh-marshal.list": No such file or directory make[3]: *** [dh-marshal.c] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory `/home/travis/build/geany/geany-plugins/_build/devhelp/devhelp' ``` I got the impression that this sometimes happens and sometimes not. But it's not related to the treebrowser changes.
I saw this and I don't see any issue with the Devhelp make file, it looks pretty normal. Also some other PRs are not failing which is weird. @b4n any ideas? I haven't tried to do a `make distcheck` in a long time for GP.
See #878
@medovina: do you request any more changes? I would like to merge this soon.
Fine with me to merge.
Merged #864 into master.
github-comments@lists.geany.org