I recently saw this message after creating a pull request.
> This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002 > > Linux Build > GitHub Actions has encountered an internal error when running your job. > > CI Build: .github#L1 > The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1239
-- Commit Summary --
* Update GitHub workflow to Ubuntu 20.04
-- File Changes --
M .github/workflows/build.yml (12)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1239.patch https://github.com/geany/geany-plugins/pull/1239.diff
@xiota pushed 1 commit.
afc78ddf6c32c3072b31b26bb53c687954bbda55 Add back some dependencies to workflow
@elextr commented on this pull request.
@@ -127,7 +127,7 @@ jobs:
# markdown libmarkdown2-dev # markdown/webhelper - libwebkitgtk-3.0-dev + libwebkit2gtk-4.0-dev
IIUC Webkit2 is not a drop in replacement for Webkit, their APIs diverge, so unless those plugins are updated to webkit2 this is wrong.
@xiota commented on this pull request.
@@ -127,7 +127,7 @@ jobs:
# markdown libmarkdown2-dev # markdown/webhelper - libwebkitgtk-3.0-dev + libwebkit2gtk-4.0-dev
`libwebkit2gtk-4.0-dev` is the dependency being used in the current Ubuntu [`geany-plugins`](http://archive.ubuntu.com/ubuntu/pool/universe/g/geany-plugins/geany-plugins...) package. `libwebkitgtk-3.0-dev` doesn't exist anymore after 18.04.
Getting a distcheck failure related to `vte`. It may not build anymore on Ubuntu 20.04 because it's not in the repository.
@elextr commented on this pull request.
@@ -127,7 +127,7 @@ jobs:
# markdown libmarkdown2-dev # markdown/webhelper - libwebkitgtk-3.0-dev + libwebkit2gtk-4.0-dev
I was aware that webkit was no longer available, but IIUC the plugins have not yet been updated (see #1217 and #1224)
See #1217
@xiota pushed 1 commit.
8567c5278da79cdc18746ac95bf4118b2ade0269 Remove devhelp and multiterm dependencies
@xiota commented on this pull request.
@@ -127,7 +127,7 @@ jobs:
# markdown libmarkdown2-dev # markdown/webhelper - libwebkitgtk-3.0-dev + libwebkit2gtk-4.0-dev
The Markdown plugin does work with `libwebkit2gtk-4.0-dev`. GeanyPy is gone for other reasons. I don't know about MultiTerm, I vaguely recall it had other issues. WebHelper, I understood was using an even older version of webkitgtk than Markdown.
@xiota pushed 1 commit.
a6ffdb5acfa36999b80676357667541c58662349 Workflow, disable: devhelp, geanypy, multiterm, webhelper
@elextr commented on this pull request.
@@ -127,7 +127,7 @@ jobs:
# markdown libmarkdown2-dev # markdown/webhelper - libwebkitgtk-3.0-dev + libwebkit2gtk-4.0-dev
Ok, since markdown is already updated (but didn't update this) and webhelper is updated by #1224 (and it doesn't update this either) I guess its ok to make this change. Certainly leaving webkit1 there is useless since its not in the distro.
P.S. I confused webhelper here and devhelper in #1217, ignore references to it other than multiterm
Looks like distcheck doesn't respect the `--disable*` options.
Thinking about it it makes sense that distcheck doesn't look at configure options, it makes a tarball that is unconfigured (but _is_ `autogen.sh`ed).
Thinking about it it makes sense that distcheck doesn't look at configure options, it makes a tarball that is unconfigured (but _is_ `autogen.sh`ed).
Is `autogen.sh` why multiterm is getting in there when it shouldn't?
Is autogen.sh why multiterm is getting in there when it shouldn't?
It just creates the `configure` shell script IIUC, so tarballers don't need autotools installed. `configure` needs to be run on the users build system.
It looks (being aware of my limitations with autotools and lack of Vala knowledge) that the autotools vala dist tries to pre-compile vala to C and will distribute that so no valac is needed? Vala knowledgable users answers on a postcard please.
@xiota pushed 2 commits.
00ab93929840cf88b8d14b8d5f04eddc432500d6 Disable multiterm in Makefile.am 271bb6008885595d868baf01ea62735f7261e82b Revert "Workflow, disable: devhelp, geanypy, multiterm, webhelper"
When I run distcheck locally (not using Ubuntu though), the problem is vala cannot find vte. Maybe there is a separate package that vala needs to use vte?
The reason the `--disable-*` flags don't work is distcheck runs configure *after* whatever it's doing that's failing.
I'm going to try disabling multiterm in `Makefile.am`. The lines are just commented out, so if multiterm is ever fixed, the lines can be easily restored.
distcheck is evil: ``` config.status: error: cannot find input file: `multiterm/Makefile.in' ```
Sigh!!!
The best thing to do is to update #1217 to not remove webhelper (since #1224 fixes it) and then remove multiterm, and we might get our CI back again.
I'll test a more complete removal of multiterm to see what happens. Can revert if it goes bad or otherwise unwanted.
Just copy the relevant parts of #1217 I guess
@xiota pushed 1 commit.
47d383eef6f6b0869b61768275037f8dffa9816b Remove multiterm
@xiota pushed 1 commit.
01faecc2dde77f5b188f3d30d1317e9405b15c45 Remove more pieces of multiterm
@xiota pushed 1 commit.
e831ca1eb3eec50fb1ab6095cb23e2a7d419de92 Use actions/checkout@v3 and actions/cache@v3 in workflow
Changed to `actions/checkout@v3` and `actions/cache@v3` because of message:
Node.js 12 actions are deprecated. ...
There are some more messages.
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-sta...
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-sta...
@xiota pushed 1 commit.
5f6bf44a760c1470108225921bbe27fede592e88 Replace set-output with $GITHUB_OUTPUT
@xiota before you are continuing, please note that most of the what you are trying to do is already done in: https://github.com/geany/geany-plugins/pull/1201/files#diff-5c3fa597431eda03...
And the PR #1201 is only waiting for #1217 which will remove the problematic plugins.
Since both PRs already exist and are almost finished, I think you could stop working on this one.
I'll try to update #1217 soon so that it can be merged and then also #1201 and we are done.
Done in #1201.
Closed #1239.
github-comments@lists.geany.org