I changed all occurrences of ```geanylatex``` to ```latex```.
In ```geany-plugins.nsi``` I kept ```geanylatex``` and added ```latex```. So both DLL's should be removed on un-install. I hope the un-installer does not throw an error if a file to-be-deleted does not exist.
ToDo's: - change pdf documentation - change screenshots - eventually adjust config handling to read in config for ```geanylatex``` and ```latex```?
**One question:** How can an old/renamed lib be un-installed under linux? Is it possible/does the build system support it? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/632
-- Commit Summary --
* geanylatex: renamed folder to latex * geanylatex: renamed more files * geanylatex: adjusted files content to new plugin name
-- File Changes --
M MAINTAINERS (2) M Makefile.am (4) M README (2) M build/geany-plugins.nsi (1) D build/geanylatex.m4 (10) A build/latex.m4 (10) M configure.ac (2) R latex/ABOUT (2) R latex/AUTHORS (0) R latex/COPYING (0) R latex/ChangeLog (0) R latex/INSTALL (2) R latex/Makefile.am (2) R latex/NEWS (0) R latex/README (0) R latex/THANKS (0) R latex/TODO (0) R latex/doc/Makefile.am (16) R latex/doc/img/bibtex_reference.png (0) R latex/doc/img/insert_environment.png (0) R latex/doc/img/insert_label.png (0) R latex/doc/img/insert_reference.png (0) R latex/doc/img/insert_usepackage.png (0) R latex/doc/img/latexwizard.png (0) R latex/doc/img/plugin_manager.png (0) R latex/doc/img/toolbar.png (0) R latex/doc/latex.css (0) R latex/doc/latex.html (146) R latex/doc/latex.pdf (0) R latex/doc/latex.tex (16) R latex/doc/latex2.html (4) R latex/doc/latex3.html (4) R latex/doc/latex4.html (4) R latex/src/Makefile.am (14) R latex/src/bibtex.c (0) R latex/src/bibtex.h (2) R latex/src/bibtexlabels.c (2) R latex/src/datatypes.h (0) R latex/src/formatpatterns.c (2) R latex/src/formatutils.c (0) R latex/src/formatutils.h (2) R latex/src/latex.c (18) R latex/src/latex.h (6) R latex/src/latexencodings.c (2) R latex/src/latexencodings.h (0) R latex/src/latexenvironments.c (0) R latex/src/latexenvironments.h (2) R latex/src/latexkeybindings.c (0) R latex/src/latexkeybindings.h (2) R latex/src/latexstructure.c (0) R latex/src/latexstructure.h (2) R latex/src/latexutils.c (2) R latex/src/latexutils.h (2) R latex/src/letters.c (0) R latex/src/letters.h (2) R latex/src/reftex.c (0) R latex/src/reftex.h (2) R latex/src/templates.c (2) R latex/src/templates.h (2) M po/POTFILES.in (28)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/632.patch https://github.com/geany/geany-plugins/pull/632.diff
In ```geany-plugins.nsi``` I kept ```geanylatex``` and added ```latex```. So both DLL's should be removed on un-install. I hope the un-installer does not throw an error if a file to-be-deleted does not exist.
Yep, it's fine this way. NSIS handle deleting non-existing files gracefully which is what we want here.
How can an old/renamed lib be un-installed under linux? Is it possible/does the build system support it?
I don't think anyone bothered last time plugins were renamed but I think you could do it by using a custom `uninstall-local` target. @b4n or @sardemff7 or someone probably has a better idea how.
[This](https://github.com/LarsGit223/geany-plugins/blob/299176db7ceb987c09ce4c63b4e...) changes the directory where the config is stored. How do you get the users existing configuration copied over?
I started to this some tim eago https://github.com/frlan/geany-plugins/tree/feature/rename_geanylatex
@elextr: It doesn't. That's why I mentioned it on the ToDo's. Can we boldly copy over the settings to a new file? Or rename the file if we see it under the old name?
@frlan: sorry, didn't know that. How far are you? If you want to send over a PR yourself than I can close this?
Can we boldly copy over the settings to a new file? Or rename the file if we see it under the old name?
I don't know, thats why I asked the question :)
The experts will have to say if the installation can be made to copy the settings file (including on windows) or if the plugin itself will have to do it and if rename or copy is needed (especially on widnows).
Well, I thought copying in the source code. I think there is a standard C remove command. But we would also need a command to remove the old dir and create a new one. Not sure if there is a standard C lib call for it across Linux, Windows and Mac.
Forget my question, found the GIO functions. That should do it.
Closes #313.
@LarsGit223 pushed 1 commit.
977729a geanylatex: move old config file to new folder
frlan commented on this pull request.
@@ -53,7 +53,7 @@
\dedication{\normalsize \textbf{Note:} Please note that this document has been created on \today. If you are using a devel version from GIT, please compile and check -\texttt{doc/geanylatex.tex} from sources. Please check Page \pageref
I woul'd rather keep the name of old version ins ChangeLog as they are.
LarsGit223 commented on this pull request.
@@ -53,7 +53,7 @@
\dedication{\normalsize \textbf{Note:} Please note that this document has been created on \today. If you are using a devel version from GIT, please compile and check -\texttt{doc/geanylatex.tex} from sources. Please check Page \pageref
Maybe I am misunderstanding something but in that line it is only the name of the latex documentation. Not the name printed inside the log. Should I only change that line or a different one?
frlan commented on this pull request.
@@ -53,7 +53,7 @@
\dedication{\normalsize \textbf{Note:} Please note that this document has been created on \today. If you are using a devel version from GIT, please compile and check -\texttt{doc/geanylatex.tex} from sources. Please check Page \pageref
At this very point the plugin was called GeanyLATeX so I'm voting for not changing that part of documentation, which is pretty much the ChangeLog.
frlan commented on this pull request.
@@ -53,7 +53,7 @@
\dedication{\normalsize \textbf{Note:} Please note that this document has been created on \today. If you are using a devel version from GIT, please compile and check -\texttt{doc/geanylatex.tex} from sources. Please check Page \pageref
Oh. My fault. I pointed to the wrong line. Sorry.
LarsGit223 commented on this pull request.
@@ -53,7 +53,7 @@
\dedication{\normalsize \textbf{Note:} Please note that this document has been created on \today. If you are using a devel version from GIT, please compile and check -\texttt{doc/geanylatex.tex} from sources. Please check Page \pageref
Ähemm..ok. Can you please point me to the right line? Or just send an PR.
frlan commented on this pull request.
@@ -53,7 +53,7 @@
\dedication{\normalsize \textbf{Note:} Please note that this document has been created on \today. If you are using a devel version from GIT, please compile and check -\texttt{doc/geanylatex.tex} from sources. Please check Page \pageref
Completely my failure. Sorry. Nevermind.
Merged #632.
github-comments@lists.geany.org