Hello!
At present, each struct has 8 padding bytes.
Found by: [scan-build](https://clang-analyzer.llvm.org/scan-build.html) You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2959
-- Commit Summary --
* <a href="https://github.com/geany/geany/pull/2959/commits/6b8832f5bdf508b69c561ea4dc78dc6016860f4e">Rearrange struct memebers to remove padding bytes</a>
-- File Changes --
M src/highlightingmappings.h (2056)
-- Patch Links --
https://github.com/geany/geany/pull/2959.patch https://github.com/geany/geany/pull/2959.diff
There are 1028 lines removed and replaced, at 4 bytes per line thats 4k bytes of program memory which is not material.
The structures are only used for initialisation and configuration, so its not on any fast path, so cache effects are also not material.
It would also take a significant effort to check and verify every language type still works which is not available.
Sorry to sound harsh, but it seems like a lot of noise and effort for no significant gain.
thats 4k bytes of program memory which is not material.
4k bytes of memory saved without adding any additional code.
It would also take a significant effort to check and verify
This PR could be reviewed over 2-3 days per 10-min a day as it involves only visual inspection.
Anyways, I leave it upto you maintainers wether to accept or reject the suggested change. :)
github-comments@lists.geany.org