(On my system) the "run" build commands didn't work (the opened term said the run script was not executable). For some reason the code here only made the run script executable on apple platforms. I removed this limitation to have the file chmod'ed on all unixoid platforms.
Works on my machine.
I'm very new to patches and PRs and such, lmk if i'm doing this wrong :)
Cheers You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2372
-- Commit Summary --
* Fix shell script generation in build.c
-- File Changes --
M src/build.c (3)
-- Patch Links --
https://github.com/geany/geany/pull/2372.patch https://github.com/geany/geany/pull/2372.diff
Strange that you need it on non-apple, the shell script is run with `/bin/sh -c <scriptname>` which doesn't care if its executable. Perhaps open an issue with the problem first.
Interesting, my `sh` says otherwise:
``` oskar@torres ~ % /bin/sh -c /tmp/geany_run_script_HVQX9Z.sh /bin/sh: /tmp/geany_run_script_HVQX9Z.sh: Permission denied ```
Thinking about it it makes sense - We're passing a command, not a script, `sh` ist not interpreting the contents of the script here, but just executing the single command passed: `/tmp/geany_run_script_HVQX9Z.sh`. T
Created issue at #2374
After the issue at #2374 got cleared up as a faulty terminal command, should i leave this open?
I think this change wouldn't hurt and having to add `/bin/sh` to the terminal command is not very intuitive.
@techee @elextr ?
I would personally do the opposite - remove the ifdef code completely as it's not needed. I just did it in https://github.com/geany/geany/pull/2363.
Even though the default isn't very intuitive, running the executable directly from tmp doesn't work on all distributions so it's not something we should rely on.
Agree with @techee
Closed #2372.
github-comments@lists.geany.org