You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1358
-- Commit Summary --
* Addons: Remove obsolete GTK_CHECK_VERSION checks
-- File Changes --
M addons/src/addons.c (2) M addons/src/ao_doclist.c (17) M addons/src/ao_systray.c (16)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1358.patch https://github.com/geany/geany-plugins/pull/1358.diff
@b4n requested changes on this pull request.
LGTM apart from the comment
-#if ! GTK_CHECK_VERSION(2, 10, 0)
gtk_widget_hide(check_systray); -#endif
Looks backwards, should you also remove the body? I guess the idea was not to add the option when the feature wasn't supported, wasn't it?
@eht16 pushed 1 commit.
678c81edbf221adedb2917e327062365b178d33a fixup: remove left-over systray call
@eht16 commented on this pull request.
-#if ! GTK_CHECK_VERSION(2, 10, 0)
gtk_widget_hide(check_systray); -#endif
This is so me...you are completely right. Thanks for spotting, fixed.
Funny thing, this attempt to hide the option didn't work at all because in Geany itself we call `gtk_widget_show_all()` when creating the plugin preferences dialog and so it was shown again. Anyway, GTK2 is long time ago.
@b4n approved this pull request.
LGBI with a little squashing
Merged #1358 into master.
github-comments@lists.geany.org