Please note that all except two typos were found by the tool `codespell`. However, I have verified and correct them all by myself and am now going blind -- err, I mean, I won't do the rest by hand.
Some of these corrections may need special attention, most importantly:
# Logfile rotation script for snort writen by jameso@elwood.net. ./tests/ctags/3526726.tex:2406
This sounds like it was taken from a third-party script, and *that* script should be fixed, too.
These are the codespell results that look like a true positive, but were ignored by me for some reason:
(ignored, because these are't trivial to correct) ./tagmanager/ctags/vhdl.c:71: atribute ==> attribute ./tagmanager/ctags/vhdl.c:71: atributes ==> attributes ./data/filetypes.fortran:7: inot ==> into ./data/php.tags:3358: lenght ==> length ./data/filetypes.f77:23: inot ==> into
(ignored, because these are "ancient" changelogs) ./ChangeLog.pre-1-22:3811: everytime ==> every time ./ChangeLog.pre-1-22:5139: accidently ==> accidentally ./ChangeLog.pre-0-17:441: occurences ==> occurrences ./ChangeLog.pre-0-17:2448: accessable ==> accessible ./ChangeLog.pre-0-17:3134: supress ==> suppress ./ChangeLog.pre-0-17:3211: contributers ==> contributors ./ChangeLog.pre-0-17:4732: translaters ==> translators ./ChangeLog.pre-0-17:5851: improvments ==> improvements ./ChangeLog.pre-0-17:9771: entitity ==> entity
(ignored, because these are very consistent) ./tests/ctags/3526726.tex:2421: todays ==> today's | disable because of var names ./tests/ctags/3526726.tex:2423: todays ==> today's | disable because of var names ./tests/ctags/3526726.tex:2432: Todays ==> Today's | disable because of var names ./tests/ctags/3526726.tex:2433: Todays ==> Today's | disable because of var names ./tests/ctags/3526726.tex:2460: todays ==> today's | disable because of var names ./tests/ctags/3526726.tex:2466: todays ==> today's | disable because of var names
(ignored, because these are variable names) ./tests/ctags/test.vhd:360: scaleable ==> scalable ./tests/ctags/test.vhd:4475: scaleable ==> scalable ./tests/ctags/test.vhd:4492: scaleable ==> scalable ./tests/ctags/test.vhd:4502: scaleable ==> scalable ./tests/ctags/test.vhd:4518: scaleable ==> scalable ./tests/ctags/test.vhd:4661: scaleable ==> scalable ./tests/ctags/test.vhd:4688: scaleable ==> scalable ./tests/ctags/test.vhd:4700: scaleable ==> scalable ./tests/ctags/test.vhd:4761: scaleable ==> scalable ./tests/ctags/test.vhd:6427: scaleable ==> scalable ./tests/ctags/test.vhd:6434: scaleable ==> scalable ./tests/ctags/test.vhd:6448: scaleable ==> scalable ./tests/ctags/test.vhd:6483: scaleable ==> scalable
(ignored, because I don't wanna go full grammar-nazi on you) ./tests/ctags/3526726.tex:688: wont ==> won't, wont ./tests/ctags/bug726712.f90:70: wont ==> won't, wont ./tests/ctags/mode.php:97: WONT ==> WON'T, WONT ./scintilla/src/ScintillaBase.cxx:279: Wont ==> Won't, wont ./scintilla/src/ScintillaBase.cxx:308: Wont ==> Won't, wont ./tagmanager/src/tm_workspace.c:1172: wanna ==> want to | disabled because one might want to allow informal pronunciation
Furthermore, please look at this:
alert("result of substract="+subtract(10,2)); // result is 8 ./tests/ctags/jsFunc_tutorial.js:125
Nothing important about it, I just wanted to point out that the author named the function correctly (`subtract`) but made a typo in the debug string (`subStract`). I find it funny :) You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/849
-- Commit Summary --
* Fix obvious typo * Fix typos * Typos overlooked by codespell
-- File Changes --
M HACKING (4) M README.Packagers (2) M doc/Doxyfile.in (2) M doc/geany.txt (8) M doc/plugins.dox (8) M geany.spec.in (2) M scintilla/lexers/LexCaml.cxx (6) M scintilla/lexers/LexCmake.cxx (2) M scintilla/src/SVector.h (2) M src/plugindata.h (4) M src/plugins.c (4) M src/pluginutils.c (4) M tagmanager/ctags/actionscript.c (2) M tagmanager/ctags/c.c (4) M tagmanager/ctags/ctags.c (2) M tagmanager/ctags/entry.c (2) M tagmanager/ctags/entry.h (2) M tagmanager/ctags/haxe.c (2) M tagmanager/ctags/html.c (2) M tagmanager/ctags/js.c (4) M tagmanager/ctags/json.c (2) M tagmanager/ctags/sql.c (4) M tagmanager/src/tm_tag.c (2) M tagmanager/src/tm_workspace.c (2) M tests/ctags/3526726.tex (16) M tests/ctags/bug1111214.v (2) M tests/ctags/bug612019.pas (2) M tests/ctags/bug852368.cpp (4) M tests/ctags/jsFunc_tutorial.js (2) M tests/ctags/lanus.for (2) M tests/ctags/members.f90 (2) M tests/ctags/misc_types.f (2) M tests/ctags/moniker.x68.asm (14)
-- Patch Links --
https://github.com/geany/geany/pull/849.patch https://github.com/geany/geany/pull/849.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/849
Thanks for this.
Sum uv oose r nut grate spullers or ytpists, and/or English isn't a first language, so its good for occasional checks.
All your included list look ok, and the excluded list looks sensible.
The files in the `scintilla` directory come from the upstream [Scintilla project](www.scintilla.org) and your changes will be overwritten next update, so those should be submitted there.
If you are feeling helpful, the files in the `tagmanager/ctags` and `test/ctags` directories may have an upstream at https://github.com/universal-ctags/ctags, but because we have modifications in out copies they are often not synced. You might want to submit the fixes there too.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/849#issuecomment-168556914
Merged #849.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/849#event-506883606
./tagmanager/ctags/vhdl.c:71: atribute ==> attribute ./tagmanager/ctags/vhdl.c:71: atributes ==> attributes ```
We can fix those, because upstream CTags doesn't have them, and they aren't used at all in fact. Fixed in 4a2890667e47af88212819e85061948f82788ad5
`./data/filetypes.fortran:7: inot ==> into` `./data/filetypes.f77:23: inot ==> into`
This actually isn't a typo. AIUI it means "i not", which seems to be `not` on some some kind of short integer in Fortran. (see http://physik.uibk.ac.at/hephy/praktikum/fortran_manual.pdf, p195).
`./data/php.tags:3358: lenght ==> length`
This is auto-generated from PHP's docs, so we don't really want to fix this manually. It's buggy uptream too in the signature: https://secure.php.net/manual/en/function.ps-open-image.php
`(ignored, because these are "ancient" changelogs)` […]
We could fix those, but it probably doesn't matter much indeed.
`(ignored, because these are very consistent)`
We could fix this too, but it's in a test file we didn't even write ourselves, so I'd just ignore those.
`(ignored, because these are variable names)`
ditto
(ignored, because I don't wanna go full grammar-nazi on you) ./tests/ctags/3526726.tex:688: wont ==> won't, wont ./tests/ctags/bug726712.f90:70: wont ==> won't, wont ./tests/ctags/mode.php:97: WONT ==> WON'T, WONT ./scintilla/src/ScintillaBase.cxx:279: Wont ==> Won't, wont ./scintilla/src/ScintillaBase.cxx:308: Wont ==> Won't, wont ```
Those are either in Scintilla (upstream project as @elextr pointed out), or in some test files, so I don't really care. Though maybe a naive person not knowing "won't" might get confused as "wont" an actual word. But well.
`./tagmanager/src/tm_workspace.c:1172: wanna ==> want to | disabled because one might want to allow informal pronunciation`
I'd fix this one, but I'll leave it for now as another PR will remove the whole function and I don't want to create merge conflicts just for this.
---
BTW, thanks a bunch for this tireless hunting!
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/849#issuecomment-169323514
Upstream bug at scintilla: https://sourceforge.net/p/scintilla/bugs/1801/
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/849#issuecomment-169852873
Neat, thanks for this.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/849#issuecomment-169853635
github-comments@lists.geany.org