@andy5995 commented on this pull request.

• GeanyDocument *doc = document_get_current();

+ + if (doc != NULL && pin_list == NULL) + { + GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name); + gtk_widget_show(label); + gtk_box_pack_start(GTK_BOX(pinned_view_vbox), label, FALSE, FALSE, 0); + gtk_notebook_set_current_page(GTK_NOTEBOOK(plugin->geany_data->main_widgets->sidebar_notebook), page_number); + } +} + + +static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata) +{ + GtkWidget *main_menu_item; + GSList *pin_list = NULL;

How do I pass 'pin_list' to pin_activate_cb()? It seems like I can't just add a 3rd argument, or it's getting ignored. :(

Uhhh, that sounds interesting and like something I want to implement since some years already :).

Uhhh, that sounds interesting and like something I want to implement since some years already :).

I just found some old code and it seems I started with a similar approach some time ago: https://gist.github.com/eht16/15afd001f238f77f100a43e4129b8d20 Use what is helpful but with care :smile:. I don't remember much its state except that it was working to some extend but quite buggy and probably also crashed happily.

@andy5995 commented on this pull request.

• GeanyDocument *doc = document_get_current();

+ + if (doc != NULL && pin_list == NULL) + { + GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name); + gtk_widget_show(label); + gtk_box_pack_start(GTK_BOX(pinned_view_vbox), label, FALSE, FALSE, 0); + gtk_notebook_set_current_page(GTK_NOTEBOOK(plugin->geany_data->main_widgets->sidebar_notebook), page_number); + } +} + + +static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata) +{ + GtkWidget *main_menu_item; + GSList *pin_list = NULL;

Thank you! I'm not good at reading code, but I got the general idea of what needed to be done.

@andy5995 pushed 4 commits.

50209670e24d25b8188f4d2aad5336749d72a7d0 Add Pinner plugin 5def3d767465a138aee70a8ce81787b8e83da130 Check for duplicates 3a293072756b34cee614c80ac329fd1e0bf2f3df check if doc eq NULL 4bb86a95810c5da704794d924e11cfae11a44fef use g_strdup instead of strlcpy, point better

Duplicate checking works now. Any feedback on how I'm implementing this so far?

One thing I'm not sure of yet is how to pass the the list to the cleanup function so I can free it.

@andy5995 commented on this pull request.

+static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata) +{ + GtkWidget *main_menu_item; + + struct pindata *container = init_pindata(); + container->plugin = plugin; + + // Create a new menu item and show it + main_menu_item = gtk_menu_item_new_with_mnemonic("Pin Document"); + gtk_widget_show(main_menu_item); + gtk_container_add(GTK_CONTAINER(plugin->geany_data->main_widgets->tools_menu), + main_menu_item); + g_signal_connect(main_menu_item, "activate", + G_CALLBACK(pin_activate_cb), container); + g_signal_connect(pinned_view_vbox, "button-press-event",

No popup menu appears and I see in the console:

``` (geany:1064826): GLib-GObject-CRITICAL **: 10:20:24.486: invalid (NULL) pointer instance

(geany:1064826): GLib-GObject-CRITICAL **: 10:20:24.486: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed ```

I think using 'pinned_view_vbox' as the 2nd argument here is not correct.

I get no compiler warnings.

@andy5995 pushed 1 commit.

c1899e4369a9f5aea2266439e4355231640957b8 Make list global

@andy5995 pushed 1 commit.

afeeb5952c1f9a56aa15117c723ecebfe2c20ba1 Remove header, make all functions static

I just found some old code and it seems I started with a similar approach some time ago: https://gist.github.com/eht16/15afd001f238f77f100a43e4129b8d20 Use what is helpful but with care 😄. I don't remember much its state except that it was working to some extend but quite buggy and probably also crashed happily.

@eht16 It looks like we were working on something different but similar? ;) I think incorporating something like that into this plugin would be suitable.

@andy5995 pushed 1 commit.

b8d66c4101dfb12d366beb30b4d1ebb2b551d0a5 Don't auto-switch to the "Pinned" tab

@andy5995 pushed 3 commits.

a1fe9573bb09b841a96e01354b65a71a10c31a20 fix double-free error when freeing list cf40001168fa9e3b9bae629edf72d6af9af04027 fix 'stack-use-after-return` in pin_cleanup 5391654fb522550bfab02bbebcfb7c6b3b01254f implement unpin, use hashtable instead of GSList

@andy5995 pushed 1 commit.

0c0a34fe8e14049b0210cf95a4bf7460dcfd610e Add credit for ChatGPT [skip ci]

@andy5995 pushed 1 commit.

259571ebebba229bffdaea28aa09e07549cf72c5 remove sanitize flag

Do you have a final screenshot?

@andy5995 pushed 1 commit.

e0d734c2d260f6d5634df335dff103be40afb2b0 Don't use 'with_mnemonic' (fix missing underscores)

Longer filenames are now handled better, and they're left-justified with a 10 pixel margin on both sides.


@luigifab

@andy5995 pushed 2 commits.

b3c3b671e74e406d95374ea0fbdd301430b1783c Add "unpin document" to right-click menu b58b98b4c8948e2d9d7081ddbcdfc0cae6a7a5b1 Add "Unpin" item to right-click popup menu

Closed #1308.

@eht16 It looks like we were working on something different but similar? ;) I think incorporating something like that into this plugin would be suitable.

Yes, my approach was for a different use case. I like to have a tab/document always in the visible area of the notebook tab list for easy access. The name of your plugin sounded like this to me in the beginning :).

write the documentation explaining what this plugin is supposed to do, sounds like it does something different to what @eht16 understood "pin" to mean, and I have always been confused about what it was meant to do.

I'm happy to elaborate an idea or re-frame a goal if I haven't made myself clear to someone. In this case, I didn't know I wasn't being understood. Please let me know next time if you are confused by my description or feel I need to expand on it more.

and do not describe it in terms of some other software, eg do not say "like firefox/eclipse/vscode/libreoffice" ;-)

I feel that's an unnecessarily rigid policy and I don't really plan to stop using them (when I believe it's appropriate) based on your demand. I believe that comparisons can be a useful tool when trying to describe something; but I acknowledge that sometimes comparisons aren't always adequate and shouldn't be solely relied upon to express a desired feature.

[end getting in ahead]

I don't know what that means.

relating to [Return NULL from document_get_current() if document is 'untitled' geany#3770](https://github.com/geany/geany/pull/3770) and depending on the answer to the above, you should be working with notebook pages, not documents. I'm pretty sure that plugins can open pages that do not have documents, let alone files.

I don't know what you mean. I work with documents when I use Geany. The plugin apparently uses a sidebar notebook (`plugin->geany_data->main_widgets->sidebar_notebook`). I use the plugin to open or switch to documents. Maybe our miscommunication stems from my lack of experience developing Geany or GTK development, but feel free to elaborate.

And a hint always check `document_valid()` on a document pointer in any callback if you pass it via the data pointer, the user can always close pages and documents or reorder pages manually.

I searched for `document_valid` in the geany-plugins source code and no results came up. When I searched for `document_get_current`, many results came up. I'm confused as to why you would suggest I use a function that no other plugin developer uses... and apparently isn't even a function included in [the API](https://www.geany.org/manual/reference/globals_func_d.html#index_d).

I'm not accessing any GeanyDocument pointers passed through a callback. In one case, I pass the file_name member as a gchar, after it's been validated by another function.

Due to [#3770](https://github.com/geany/geany/pull/3770) I use this to validate the file_name after I enter a callback function:

``` GeanyDocument* doc = document_get_current(); if (!(doc && doc->is_valid)) return;

if (doc->file_name == NULL) return; ```

but I acknowledge that sometimes comparisons aren't always adequate and shouldn't be solely relied upon to express a desired feature.

Yes, that was what I was asking, describing a feature as "I want it to work like Vscode" is unhelpful if the reader doesn't use Vscode or that feature of Vscode, whereas "I want it to do xyz when I click blah because I have found it useful in Vscode" is of course fine.

[end getting in ahead]

I was simply saying that I was making the above point as guidance ahead of you doing anything, not that it was a criticism of anything you had done in the past.

I searched for document_valid

Sorry I meant [`DOC_VALID`](https://www.geany.org/manual/reference/document_8h.html#a064c8f47ec543aa26cb...) which does exactly your suggested code but allows for Geany to add conditions without your code needing to be changed. Thats not to say all plugins use it properly (or even Geany itself).

The important thing was to beware that state can change between callbacks to your plugin, I saw a note that you made a list (of documents I think) global, thats fine, but if you are saving information between callbacks you have to check that the information in that list is valid every time your plugin is entered because any arbitrary changes could be made (documents opening/closing) between callbacks.

Maybe our miscommunication stems from my lack of experience developing Geany or GTK development, but feel free to elaborate.

Or the problem of the description of the plugin. I had in mind "pin" as being locking the document tab to the left side of the notebook tabs, a feature available in several other applications. Your `README.md` definition of "pin" as adding to a sidebar list clears that up (and is probably simpler to implement).