You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2617
-- Commit Summary --
* Drop GTK2 support * Drop use of GTK2-only API * Drop use of deprecated GTK2-era GDK key names
-- File Changes --
M .travis.yml (15) M HACKING (15) M README (8) M configure.ac (19) M data/Makefile.am (5) D data/geany.gtkrc (72) M doc/plugins.dox (2) M m4/geany-mac-integration.m4 (4) M plugins/classbuilder.c (2) M plugins/demoplugin.c (2) M plugins/export.c (2) M plugins/filebrowser.c (18) M plugins/saveactions.c (20) M plugins/splitwindow.c (8) M scripts/cross-build-mingw.sh (12) M scripts/gtk-bundle-from-msys2.sh (8) M src/about.c (8) M src/build.c (29) M src/callbacks.c (5) M src/dialogs.c (5) M src/document.c (26) M src/documentprivate.h (2) M src/editor.c (20) M src/filetypesprivate.h (2) M src/gb.c (43) M src/geanywraplabel.c (43) M src/gtkcompat.h (80) M src/keybindings.c (265) M src/keybindings.h (2) M src/libmain.c (52) M src/log.c (2) M src/msgwindow.c (12) M src/navqueue.c (2) M src/notebook.c (33) M src/plugindata.h (10) M src/pluginprivate.h (2) M src/plugins.c (5) M src/pluginutils.c (2) M src/prefs.c (5) M src/printing.c (6) M src/project.c (2) M src/search.c (36) M src/sidebar.c (16) M src/socket.c (10) M src/stash.c (6) M src/symbols.c (7) M src/templates.c (3) M src/toolbar.c (6) M src/tools.c (5) M src/ui_utils.c (22) M src/vte.c (46)
-- Patch Links --
https://github.com/geany/geany/pull/2617.patch https://github.com/geany/geany/pull/2617.diff
As we're talking about dropping GTK2, here's a shot at cleaning things up. I intentionally kept some of the infrastructure to support more than one version for when we'll start GTK4 support (even though I don't yet know how that would look like) so it's a little easier; but all GTK2-related stuff should be gone.
One noteworthy thing that isn't completely gone is *gtkcompat.h* header: I dropped all actual use from Geany itself, but for the moment I have been conservative on removing it from anywhere plugins could be reaching it from.
BTW, feel free to take over if/when needed, as I am famous for lack of time lately :wink:
BTW, feel free to take over if/when needed, as I am famous for lack of time lately
If you lack time, then why spend all that time completely re-creating #2602 instead of just requesting or pushing changes to it?
Closed #2617.
@codebrainz Oops. Probably because I didn't see it, and didn't think about looking for it even -- which is stupid on my part. Well, so I'll try and see if there's anything worth in here for yours.
@b4n the GDK keysyms stuff for sure, and making the CI work. I allowed commits by maintainers on that branch and I think you have push rights on my fork anyway, feel free to just push anything you think is useful.
github-comments@lists.geany.org