1. Suggest using Github for reporting bugs and pull requests instead of sending them by email. 2. Use https:// instead of http:// 3. Mention universal-ctags as a maintained version of ctags in geanyctags README You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1348
-- Commit Summary --
* geanyctags, projectorganizer, vimode: Encourage users to use github * geanyctags, projectorganizer, vimode: Use https in URLs * geanyctags: Mention the possibility of using universal-ctags
-- File Changes --
M geanyctags/README (13) M projectorganizer/README (9) M projectorganizer/src/prjorg-main.c (2) M vimode/README (10) M vimode/src/backends/backend-geany.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1348.patch https://github.com/geany/geany-plugins/pull/1348.diff
@elextr commented on this pull request.
Couple of suggestions, otherwise looks good.
@@ -11,7 +11,9 @@ GeanyCtags adds a simple support for generating and querying ctags files for a G
project. It requires that the ctags command is installed in a system path. On unix systems, distributions usually provide the ctags package; on Windows, the ctags binary can be found in the zip Windows distribution from the ctags home -page (http://ctags.sourceforge.net). +page (https://ctags.sourceforge.net). There is also a new, maintained implementation
Given the last release of ectags was 2009 it seems better to not mention it. Uctags has 15 years of improvement and makes Windows and mac binaries.
@@ -109,9 +111,10 @@ Get the code from::
Ideas, questions, patches and bug reports =========================================
-Please direct all questions, bug reports and patches to the plugin author using the -email address listed below or to the Geany mailing list to get some help from other -Geany users. +Please direct all questions, bug reports and patches to the combined geany-plugins +project at https://github.com/geany/geany-plugins and open the corresponding +bug report or pull request there. To notify the author of this plugin about +your post, mention him using his github user name (@techee).
Maybe mention that the github username can usually be found in the MAINTAINERS file.
@techee pushed 1 commit.
de9a25bb9e7aff4c7f89677120df1f9d80e419cd geanyctags: Add information about universal-ctags
@techee commented on this pull request.
@@ -11,7 +11,9 @@ GeanyCtags adds a simple support for generating and querying ctags files for a G
project. It requires that the ctags command is installed in a system path. On unix systems, distributions usually provide the ctags package; on Windows, the ctags binary can be found in the zip Windows distribution from the ctags home -page (http://ctags.sourceforge.net). +page (https://ctags.sourceforge.net). There is also a new, maintained implementation
Good point, I've updated this section. I kept the information about ctags though so people know what the difference between ctags and universal ctags is (I think distributions still package the unmaintained ctags).
@techee commented on this pull request.
@@ -109,9 +111,10 @@ Get the code from::
Ideas, questions, patches and bug reports =========================================
-Please direct all questions, bug reports and patches to the plugin author using the -email address listed below or to the Geany mailing list to get some help from other -Geany users. +Please direct all questions, bug reports and patches to the combined geany-plugins +project at https://github.com/geany/geany-plugins and open the corresponding +bug report or pull request there. To notify the author of this plugin about +your post, mention him using his github user name (@techee).
I'll probably skip this level of indirection and mention it directly in the documentation. I normally check geany-plugins only from time to time but I have an email notification enabled when someone mentions me.
@elextr approved this pull request.
Merged #1348 into master.
github-comments@lists.geany.org