Fixes #285. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1028
-- Commit Summary --
* GeanyVC:(Git) Fallback to `git rev-parse` for getting the repo/worktree's top directory
-- File Changes --
M geanyvc/src/vc_git.c (44)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1028.patch https://github.com/geany/geany-plugins/pull/1028.diff
For some reason this fix did not make it into the 1.38. Is there any more details needed for this?
@elextr This one too has not been getting any merge-love for very much long while. Anything else for me to do to get this off my PR list?
Just re-checked, the behavior complies with the use-case listed in the #285 for what it's worth.
Just re-checked, the behavior complies with the use-case listed in the https://github.com/geany/geany-plugins/issues/285 for what it's worth.
To be clear, I don't use geanyvc, so I won't spend time understanding enough of the plugin code to be able to review the change, similarly setting up a sacrificial git repo to test it. Especially when related to git workflows and stuff.
Although it would be preferable that some other user (like the OP of #285) tests it, in the end if it sits too long and nobody does then IMHO if the plugin maintainer says so (and the build passes) it should be merged.
Can you trigger the new CI by pushing an inconsequential change, after all its a year since it was tested, I'm sure there is a comment that needs improving/adding :-)
@nomadbyte pushed 1 commit.
187dfc2aa55de6e52688d88cf8a505f1d47173cc GeanyVC:(Git) Fallback to `git rev-parse` for getting the repo/worktree's top directory
Here it is -- the commit comment now has the use-case in it too.
@elextr Do you favor a VCS other than Git? Which one?
I use git but not geanyvc (since I mostly do C/C++ and that not in Geany).
Ok, build passed, so safe(ish) to merge, since the CI builds all plugins, if one of them fails the whole build fails and so subsequent PRs all show as failing even if they are for a plugin other than the one that failed (see recent problems with Geanylua failing other plugins).
Merged #1028 into master.
github-comments@lists.geany.org