@xiota pushed 1 commit.

29757b8e743a38996bad6e2fbee71e68a9de4573 fix win32 code

IMO the biggest problem of this proposal is that it introduces yet another (this time hidden) place where project files are stored. We already have 1. Inside the project directory 2. Outside the project directory

and what this proposal does is it introduces yet another mode:

- outside the project directory at a place which isn't meant to be permanent and which is more or less hidden from normal use and where it isn't clear if it exists or not

Now imagine a user created a `my_project.geany` file inside his `basename` directory and runs Project->Open folder on it. He certainly expects the previously created project is opened like in any other editor but instead, the new, hidden project is created.

Or imagine the user just happily uses this feature only and then deletes the `.cache` directory because he thinks it contains just temporary files. Of course, it could be also in `.config` but the problem of more-or-less-invisible project files stored at a location that is totally separate from the project still remains.

IMO the main problem here is that we just simply can't implement the "Open folder" feature with the current way projects work in Geany without doing something ugly. I think there are just 2 right options here: 1. Force users to have their project file in the root of their base name (or some project directory) under a fixed name - then "Open folder" will just work like in any other editor 2. Just update existing project opening to improve existing behavior which is what I try in #3042 (and #3018 before)

As I think (1) won't pass, I tried doing (2).

What happens if user supplies two directories on command line, where both contain a project?

Previously, the project/folder would be opened/created, files added, then the next project/folder would be opened/created (closing the previous), etc. This is problematic when opening multiple files with shell globs that could refer to folders. So I'm changed the feature to use a command-line flag.

IMHO opening a project just by specifying it's directory might be confusing. If I'd want to open a project, I'd pass it's project file as argument (which already works well).

Thank you for reminding me that I need to update the manual.

The intent is to add folder handling. The mechanism is via projects. (Other editors/IDEs have been reported to behave similarly.) This is useful when combined with a plugin that displays folder contents in the sidebar. Otherwise, it's not very useful and can just be ignored.

As for passing directory on command line, much more intuitive behaviour (again just my own opinion) would be to open all files in the directory.

This behavior would also have problems with shell globs. Many folders have thousands of files, and Geany would appear to be frozen/crashed/broken while loading so many files. The current Geany behavior is to drop folders in some cases (currently, initial startup and socket behavior do not match; I've added changes to address this).

Creating a new project could be quite a surprise, especially for users who don't usually use projects.

Switching to using a command-line flag should resolve this. From the menu, there are clues that Projects are involved.

@xiota pushed 1 commit.

509c7ed06217e10a5f3702387ff0bfeb1acc1bbd more instances of g_file_new_build_filename