Automatically set the cursor position on the visible line on SCN_MARGINCLICK event You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1349
-- Commit Summary --
* Vimode: handle fold and margin click event
-- File Changes --
M vimode/src/utils.c (25) M vimode/src/utils.h (2) M vimode/src/vi.c (8)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1349.patch https://github.com/geany/geany-plugins/pull/1349.diff
@techee requested changes on this pull request.
Looks good. There's just the minor formatting issue plus I noticed that right now there's a merge conflict, probably because of the other vimode PR I merged - would you have a look at that?
You can just squash the result into one commit, I don't expect any more problems.
@@ -306,6 +306,14 @@ gboolean vi_notify_sci(SCNotification *nt)
} }
+ if (nt->nmhdr.code == SCN_MARGINCLICK) {
Maybe just { on a separate line.
@scresto09 pushed 1 commit.
0105a26a29b7dadb71c8703e47dfd63b287f9b14 Formatting issue
@scresto09 pushed 1 commit.
2c473da72b5eb9ebf9b54e02e60682697c46140f Merge branch 'master' into vimode-handle-fold-marginclick
@scresto09 You seem to have accidentally pushed the commit together with the already merged pull request - could you fix that?
@scresto09 pushed 1 commit.
d861058c49959d619f73d65c956452b2e4cfdefb Vimode: handle fold and margin click event
@scresto09 pushed 1 commit.
fade2b75401f0ef57486ef93ea854d7ff226b211 Vimode: handle fold and margin click event
Is it better now ?
Merged #1349 into master.
Yep, looks good, merged.
Thanks
github-comments@lists.geany.org