This should allow one to edit keybindings without too many surprises again. I didn't review everything though, and just fixed the couple I found (I got hit :boom: but the first crash, and suspected the second one). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4226
-- Commit Summary --
* prefs: Fix crash changing a keybinding * prefs: Edit the correct keybinding when there is a filter
-- File Changes --
M src/prefs.c (14)
-- Patch Links --
https://github.com/geany/geany/pull/4226.patch https://github.com/geany/geany/pull/4226.diff
So I'm to blame as well, I didn't notice the problem at all :-(. Thanks for noticing and fixing it.
The changes look good to me. I went through the code and I _believe_ that's all that needs to get updated.
I was also wondering about `prefs_kb_search_name()` which works on top of the filtered model now. It is used to locate the plugin keybindings from the list when pressing Keybindings in the plugin manager. But since the filter entry is cleared when the Properties dialog appears, it locates the plugin alright despite working on the filtered model.
Merged #4226 into master.
@techee thanks for testing and looking into it. I also didn't see another obvious issue (yet), neither in the changes nor using it a bit. Good thinking about the search from PM, and it's good if it's unaffected in practice :)
Yeah, I got mentioned in an issue title. This must be something good, isn't it?
Sorry for this, I completely ignored editing the keybindings and so also didn't test it :(.
Thanks for fixing!
github-comments@lists.geany.org