I ported the scope plugin to GTK3 and VTE 2.91. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/697
-- Commit Summary --
* scope: port to GTK3.
-- File Changes --
M build/scope.m4 (4) M scope/src/conterm.c (43) M scope/src/plugme.c (4) M scope/src/prefs.c (4) M scope/src/prefs.h (4) M scope/src/scope.c (12) M scope/src/utils.c (12)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/697.patch https://github.com/geany/geany-plugins/pull/697.diff
@LarsGit223 Why ```GP_CHECK_PLUGIN_GTK3_ONLY```? Is plugin don't support build with GTK2 now?
@Skif-off: no. As the PR is right now, it would only support GTK3.
@LarsGit223 Sorry, I didn't understand :) Is Geany drop to support GTK2?
@Skif-off: No. By default geany compiles/is built for GTK2. If you specify the option ```--enable-gtk3``` on build then it will be build for GTK3. Then only plugins would work with that version of geany which support GTK3.
Which OS/distro do you use? Many linux distros support both GTK versions.
To be explicit: Geany will still support GTK2. It will not be dropped.
@LarsGit223 Thanks, I was confused by the [GP_CHECK_PLUGIN_GTK**3_ONLY**](https://github.com/geany/geany-plugins/pull/697/files#diff-c6ec9ad09f6351d19...).
P.S. I use Xubuntu 17.10, but I compile on my own (I use [PR 1752](https://github.com/geany/geany/pull/1752)) and [I don't like GTK3](https://github.com/geany/geany/issues/1746).
@Skif-off To be even more explicit, geany will still support gtk2, its just the changes in this PR make this plugin gtk3 only. Which is why I keep repeating myself that it should be a separate plugin so it leaves the GTK2 version available for those lucky people where it does not hang Geany.
@LarsGit223 I don't suppose by any chance that you have removed the recursion that I understand is the trigger for the Glib bug?
@elextr: no, the changes are only regarding GTK3 and VTE compatibility.
@frlan: please don't merge this yet as there is still an open discussion how to proceed regarding GTK2 and GTK3 support.
I will not merge it when disabling Gtk2 without suitable replacement for Gtk2 users
I am closing this ion favour of PR #750.
Closed #697.
github-comments@lists.geany.org