[geany/geany] add @mesonbuild filetype support (#2850)

List overview All Threads

newer

older

[geany/geany] Update Turkish...

[geany/geany] support for fwd bkwd...

Andy Alt

21 Jul 2021 21 Jul '21

6:40 p.m.

closes #1734 You can view, comment on, or merge this pull request online at:

https://github.com/geany/geany/pull/2850

-- Commit Summary --

* add @mesonbuild filetype support

-- File Changes --

A data/filedefs/filetypes.Meson.conf (13) M data/filetype_extensions.conf (1)

-- Patch Links --

https://github.com/geany/geany/pull/2850.patch https://github.com/geany/geany/pull/2850.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Enrico Tröger

12 Sep 12 Sep

10:04 a.m.

Looks good! A few questions and remarks: - `data/filedefs/filetypes.Meson.conf` must be added in `data/Makefile.am` to `filetypes_dist`. Otherwise the config file won't be included in releases and won't be installed - it'd be nice if we would add the filetype also to the appropriate key in the`[Groups]` section in `data/filetype_extensions.conf` (this is used to place the filetype in the corresponding group in the Document->Set filetype menu) - I'm not sure where it fits best, I guess either in Scripting or Misc - would you mind sorting the keyword and identifiers list alphabetacally? This makes it easier to update in the future - could we maybe use `meson.build` in `data/filetype_extensions.conf`? `*.build` might be too greedy, it seems common to me to use `meson.build` but I'm no Meson expert :D

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-917604664

elextr

10:25 a.m.

...

could we maybe use meson.build in data/filetype_extensions.conf? *.build might be too greedy, it seems common to me to use meson.build but I'm no Meson expert :D

AFAIK it can only be meson.build so yeah the full name should be used.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-917607689

Andy Alt

13 Sep 13 Sep

2:45 a.m.

Sure, no problem. I did all the items you listed @eht16

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-917791305

Andy Alt

3:01 a.m.

@eht16 @elextr Should syntax highlighting for meson_options.txt be included as well?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-917796271

elextr

3:07 a.m.

There isn't a meson lexer, but if one of the others works well enough it could probably be used.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-917799279

Enrico Tröger

9:25 p.m.

@andy5995 not sure about `meson_options.txt`. I guess compared to `meson.build` it's maybe less often used and the synxtax doesn't seem that complicated so that highlighting is necessary.

The rest looks fine, thanks for the changes.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-918589937

Andy Alt

28 Sep 28 Sep

7:50 p.m.

...

@andy5995 not sure about `meson_options.txt`. I guess compared to `meson.build` it's maybe less often used and the synxtax doesn't seem that complicated so that highlighting is necessary.

The rest looks fine, thanks for the changes.

Sounds like this is ready for approval and merging then

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-929573319

elextr

11:58 p.m.

@elextr commented on this pull request.

...

@@ -85,5 +86,5 @@ None=*;

Programming=Arduino;Clojure;CUDA;Cython;Genie;Groovy;Kotlin;Nim;Scala;Swift; Script=Graphviz;TypeScript; Markup= -Misc=JSON; +Misc=JSON;Meson;

Cmake and Makefiles are both in the scripting group, so maybe better there.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#pullrequestreview-766070155

Andy Alt

29 Sep 29 Sep

12:19 a.m.

@andy5995 pushed 3 commits.

28f8cb3dc7b04155cc669692a72559a49f47a587 add @mesonbuild filetype support cbe78c8ad74bee6b3a2a15ca43fd6b7131339208 apply suggestions from @eht16 cfd2e1dc69012d4bacd4bba78e697ddc48d87e17 filetype_extensions:move Meson to script group

-- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2850/files/bfa66cfbeb1a6eb64fb535c8b38d7...

Andy Alt

12:19 a.m.

@andy5995 commented on this pull request.

...

@@ -85,5 +86,5 @@ None=*;

Programming=Arduino;Clojure;CUDA;Cython;Genie;Groovy;Kotlin;Nim;Scala;Swift; Script=Graphviz;TypeScript; Markup= -Misc=JSON; +Misc=JSON;Meson;

done

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#discussion_r718054298

elextr

12:26 a.m.

Looks ok to me, so all it needs is somebody who is not @andy5995 to test it and it can be merged after release.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-929720246

Enrico Tröger

30 Sep 30 Sep

5:30 a.m.

I've tested it (filetype detection, syntax highlighting, make install, make distcheck) and it works fine.

@elextr why do you want it to be merged *after* the release? For me, this could go still into 1.38.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-930796855

elextr

8:13 a.m.

I didn't mean it _had_ to be after the release. I just meant it was _likely_ to be after.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-930998226

Enrico Tröger

8:51 p.m.

Ok, great. So let's merge before 1.38 is getting out :).

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#issuecomment-931658097

Enrico Tröger

8:52 p.m.

Merged #2850 into master.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2850#event-5390308597

1114

Age (days ago)

1185

Last active (days ago)

github-comments@lists.geany.org

15 comments

3 participants

tags (0)

participants (3)

Andy Alt
elextr
Enrico Tröger