This both reduces the amount of code (by more than ⅔!), and tries to move towards a state where new contributors don't feel like using manual keyfile read/write is the way to go (experience has shown the `load_dialog_prefs()` has a way of going unnoticed -- but @elextr will come up with a nice way of documenting this :wink:).
In theory it also reduce the possibility for typos leading to settings not being saved/loaded properly (i.e. if the setting name/group doesn't match), but as it's currently working it mostly allows for mistakes in the diff of this PR :smile: Though, I should have done that carefully enough to not risk too much. But review is of course a good idea (hint hint). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1184
-- Commit Summary --
* Port some settings to Stash * Port font settings to Stash * Port the long line settings to Stash * Port remaining visibility settings to Stash * Port tab position settings to Stash * Port remaining interface tab settings to Stash * Port remaining editor settings to Stash * Port remaining simple file settings to Stash
-- File Changes --
M src/keyfile.c (273) M src/prefs.c (331)
-- Patch Links --
https://github.com/geany/geany/pull/1184.patch https://github.com/geany/geany/pull/1184.diff
Seems like a reasonable first step to get prefs all the using the same API so we can more easily switch them all at once to something more appropriate like GSettings (w/ keyfile backend).
Still need to review the code.
LGBCI
but @elextr will come up with a nice way of documenting this
Love to help, but I don't know what you are talking about (guess whatever is unnoticed is still unnoticed :)
@b4n pushed 2 commits.
a1ff5b3 Port remaining toolbar settings to Stash e128883 Port most VTE settings to Stash
@elextr what's "C" in "LGBCI"? "Code"? "Careful"?
Love to help, but I don't know what you are talking about (guess whatever is unnoticed is still unnoticed :)
Heh ^^
```C
/* note: new settings should be added in init_pref_groups() */ static void load_dialog_prefs(GKeyFile *config) { ```
On 21 August 2016 at 00:44, Colomban Wendling notifications@github.com wrote:
@elextr https://github.com/elextr what's "C" in "LGBCI"? "Code"? "Careful"?
Cursory, wouldn't want you to think I had minutely checked each setting :)
Love to help, but I don't know what you are talking about (guess whatever is unnoticed is still unnoticed :)
Heh ^^
/* note: new settings should be added in init_pref_groups() */static void load_dialog_prefs(GKeyFile *config) {
Ahhh
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/geany/geany/pull/1184#issuecomment-241203919, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxgTTBmd9OstVh-yXrsnCKReu61ekGAks5qhxK5gaJpZM4Jo8a_ .
github-comments@lists.geany.org