First set of 10 translations. I have a question regarding the menu accelerators(strings containing a "_"). I am not clear exactly what criteria is used when assigning a accelerator key ? What would be the best way to determine this and proceed please ? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3087
-- Commit Summary --
* started sinhala translations * Delete si.po * Started Sinhala Translations * Merge branch 'geany:master' into master * Added accerlerator Keys * I used fetch then pull so this is the reason why :-)
-- File Changes --
A po/si.po (5814)
-- Patch Links --
https://github.com/geany/geany/pull/3087.patch https://github.com/geany/geany/pull/3087.diff
@Aruna-Hewapathirane pushed 1 commit.
bb705b7c39d0486ee705f023431ce5b95f59d2b1 Added correct accerlerator Keys
@Aruna-Hewapathirane pushed 1 commit.
b888704c3010898113b8a8a8100ecbd84c684bdc Added 10 more translations
Friendly ping @frlan
Closed #3087.
Friendly ping @frlan
Hello, sorry been busy with life and work :-) what did you want me to do?
Reopened #3087.
@Aruna-Hewapathirane @frlan is the Geany translations manager/expert, the ping was for him, not you ;-)
@Aruna-Hewapathirane @frlan is the Geany translations manager/expert, the ping was for him, not you ;-)
Oops! My apologies.. :-)
Sorry -- here also busy and got lost in GH noise ;) Will have a review soonish
@Aruna-Hewapathirane From general point of view it looks good :+1: . Would you mind to rebase your branch on current master and squash the commits into one (or at least a low number of?)
@Aruna-Hewapathirane From general point of view it looks good +1 . Would you mind to rebase your branch on current master and squash the commits into one (or at least a low number of?)
Sure, I will do so soon.
@Aruna-Hewapathirane pushed 0 commits.
Closed #3087.
github-comments@lists.geany.org