DevHelp depends on unavailable WebKitGtk 1.x. GeanyPy and MultiTerm are GTK 2 only.
After we agreed on this, I will take care of updating the website, closing related issues and maybe more references. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1217
-- Commit Summary --
* Remove unusable plugins: DevHelp, GeanyPy, Multiterm
-- File Changes --
M .github/workflows/build.yml (9) M MAINTAINERS (21) M Makefile.am (15) M README (3) D build/devhelp.m4 (29) M build/geany-plugins.nsi (2) D build/geanypy.m4 (39) M build/gtk.m4 (6) D build/multiterm.m4 (13) D build/vala.m4 (35) M configure.ac (3) D devhelp/AUTHORS (1) D devhelp/COPYING (674) D devhelp/ChangeLog (0) D devhelp/INSTALL (365) D devhelp/Makefile.am (4) D devhelp/NEWS (16) D devhelp/README (114) D devhelp/autogen.sh (6) D devhelp/configure.ac (20) D devhelp/data/Makefile.am (10) D devhelp/data/devhelp-plugin-48.png (0) D devhelp/data/devhelp-plugin.svg (467) D devhelp/data/devhelp.conf (67) D devhelp/data/geany-devhelp-plugin.png (0) D devhelp/data/geany-devhelp.png (0) D devhelp/data/home.html (16) D devhelp/devhelp/Makefile.am (83) D devhelp/devhelp/dh-assistant-view.c (465) D devhelp/devhelp/dh-assistant-view.h (59) D devhelp/devhelp/dh-assistant.c (130) D devhelp/devhelp/dh-assistant.h (54) D devhelp/devhelp/dh-base.c (307) D devhelp/devhelp/dh-base.h (62) D devhelp/devhelp/dh-book-manager.c (408) D devhelp/devhelp/dh-book-manager.h (61) D devhelp/devhelp/dh-book-tree.c (385) D devhelp/devhelp/dh-book-tree.h (55) D devhelp/devhelp/dh-book.c (246) D devhelp/devhelp/dh-book.h (67) D devhelp/devhelp/dh-enum-types.c (133) D devhelp/devhelp/dh-enum-types.c.template (47) D devhelp/devhelp/dh-enum-types.h (26) D devhelp/devhelp/dh-enum-types.h.template (27) D devhelp/devhelp/dh-error.c (35) D devhelp/devhelp/dh-error.h (42) D devhelp/devhelp/dh-keyword-model.c (545) D devhelp/devhelp/dh-keyword-model.h (69) D devhelp/devhelp/dh-link.c (291) D devhelp/devhelp/dh-link.h (72) D devhelp/devhelp/dh-marshal.c (148) D devhelp/devhelp/dh-marshal.h (52) D devhelp/devhelp/dh-marshal.list (6) D devhelp/devhelp/dh-parser.c (611) D devhelp/devhelp/dh-parser.h (36) D devhelp/devhelp/dh-preferences.c (417) D devhelp/devhelp/dh-preferences.h (34) D devhelp/devhelp/dh-search.c (725) D devhelp/devhelp/dh-search.h (60) D devhelp/devhelp/dh-util.c (812) D devhelp/devhelp/dh-util.h (67) D devhelp/devhelp/dh-window.c (1982) D devhelp/devhelp/dh-window.h (73) D devhelp/devhelp/eggfindbar.c (755) D devhelp/devhelp/eggfindbar.h (81) D devhelp/devhelp/ige-conf-gconf.c (387) D devhelp/devhelp/ige-conf-mac.c (342) D devhelp/devhelp/ige-conf-private.h (54) D devhelp/devhelp/ige-conf.c (337) D devhelp/devhelp/ige-conf.h (87) D devhelp/doc/Doxyfile (1630) D devhelp/m4/libtool.m4 (7377) D devhelp/m4/ltoptions.m4 (368) D devhelp/m4/ltsugar.m4 (123) D devhelp/m4/ltversion.m4 (23) D devhelp/m4/lt~obsolete.m4 (92) D devhelp/src/Makefile.am (32) D devhelp/src/dhp-manpages.c (240) D devhelp/src/dhp-object.c (1391) D devhelp/src/dhp-plugin.c (230) D devhelp/src/dhp-plugin.h (35) D devhelp/src/dhp-settings.c (349) D devhelp/src/dhp.h (140) D geanypy/AUTHORS (2) D geanypy/COPYING (339) D geanypy/ChangeLog (1) D geanypy/Makefile.am (4) D geanypy/NEWS (1) D geanypy/README (88) D geanypy/doc/make.bat (170) D geanypy/doc/source/api.rst (67) D geanypy/doc/source/app.rst (40) D geanypy/doc/source/conf.py (216) D geanypy/doc/source/dialogs.rst (55) D geanypy/doc/source/document.rst (199) D geanypy/doc/source/geany.rst (0) D geanypy/doc/source/index.rst (26) D geanypy/doc/source/install.rst (146) D geanypy/doc/source/intro.rst (8) D geanypy/doc/source/quickstart.rst (121) D geanypy/doc/source/starting.rst (60) D geanypy/geany/Makefile.am (17) D geanypy/geany/__init__.py (71) D geanypy/geany/console.py (666) D geanypy/geany/logger.py (74) D geanypy/geany/plugin.py (0) D geanypy/geany/signalmanager.py (0) D geanypy/m4/ax_python_devel.m4 (0) D geanypy/m4/ax_python_library.m4 (0) D geanypy/plugins/Makefile.am (0) D geanypy/plugins/console.py (0) D geanypy/plugins/demo.py (0) D geanypy/plugins/hello.py (0) D geanypy/src/Makefile.am (0) D geanypy/src/geanypy-app.c (0) D geanypy/src/geanypy-dialogs.c (0) D geanypy/src/geanypy-document.c (0) D geanypy/src/geanypy-document.h (0) D geanypy/src/geanypy-editor.c (0) D geanypy/src/geanypy-editor.h (0) D geanypy/src/geanypy-encoding.c (0) D geanypy/src/geanypy-encoding.h (0) D geanypy/src/geanypy-filetypes.c (0) D geanypy/src/geanypy-filetypes.h (0) D geanypy/src/geanypy-glog.c (0) D geanypy/src/geanypy-highlighting.c (0) D geanypy/src/geanypy-indentprefs.c (0) D geanypy/src/geanypy-interfaceprefs.c (0) D geanypy/src/geanypy-keybindings.c (0) D geanypy/src/geanypy-keybindings.h (0) D geanypy/src/geanypy-main.c (0) D geanypy/src/geanypy-mainwidgets.c (0) D geanypy/src/geanypy-msgwindow.c (0) D geanypy/src/geanypy-navqueue.c (0) D geanypy/src/geanypy-plugin.c (0) D geanypy/src/geanypy-plugin.h (0) D geanypy/src/geanypy-prefs.c (0) D geanypy/src/geanypy-project.c (0) D geanypy/src/geanypy-project.h (0) D geanypy/src/geanypy-scinotification.c (0) D geanypy/src/geanypy-scinotifyheader.c (0) D geanypy/src/geanypy-scintilla.c (0) D geanypy/src/geanypy-scintilla.h (0) D geanypy/src/geanypy-search.c (0) D geanypy/src/geanypy-signalmanager.c (0) D geanypy/src/geanypy-signalmanager.h (0) D geanypy/src/geanypy-templates.c (0) D geanypy/src/geanypy-uiutils.c (0) D geanypy/src/geanypy-uiutils.h (0) D geanypy/src/geanypy.h (0) D geanypy/src/makefile.win32 (0) D multiterm/.gitignore (0) D multiterm/AUTHORS (0) D multiterm/COPYING (0) D multiterm/ChangeLog (0) D multiterm/Makefile.am (0) D multiterm/NEWS (0) D multiterm/README (0) D multiterm/TODO (0) D multiterm/src/Makefile.am (0) D multiterm/src/config.vala (0) D multiterm/src/context-menu.vala (0) D multiterm/src/defconf.vala (0) D multiterm/src/notebook.vala (0) D multiterm/src/plugin.vala (0) D multiterm/src/shell-config.vala (0) D multiterm/src/tab-label.vala (0) D multiterm/src/terminal.vala (0) D multiterm/src/vapi/geany.deps (0) D multiterm/src/vapi/geany.vapi (0) M po/POTFILES.in (0) M po/POTFILES.skip (0)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1217.patch https://github.com/geany/geany-plugins/pull/1217.diff
It feels weird to delete plugins from @b4n, @kugel- and @codebrainz :upside_down_face:
I guess you do not intend to update any of those plugins?
Well to be fair, Geanypy has a dependency that has stated it will never be newer than GTK2, so "upgrading" would be a rewrite.
So since it was a rewrite @kugel- replaced Geanypy with Peasy, which is also better, just its not been added to GP. I think its in some distros (Arch AUR at least), but not Debian or Fedora and their derivatives.
Similarly IIUC Webkit2 (now just webkit) is a rewrite, and not API compatible, but how much work a port would be I don't know, not simple I guess or it would be done :sob:
Probably removing these is the best thing, then anybody who wants/can "upgrade" them can get the source from git tag 1.38 as a reference or starting point and submit a shiny new plugin witjhout having to handle any backwards compatibility.
re WebHelper, I kind of plan to port it to something not dead someday (webkit2), but it's been a long while and it didn't happen, mostly as @elextr mentioned because it means some non-trivial rewrites. Also, I don't actually use that plugin very much (otherwise I probably would have picked this up by then), and mostly wrote it as a feature request if I recall.
If people care, I could possibly try and revamp an old webkit2 port attempt (I think Debian had something back in the days as well), but I wasn't wholly happy about t because it didn't have full feature parity. And who knows, maybe it'd give somebody else ideas. Yet if nobody cares, you can also drop it, I won't cry on its demise :shrug:
@eht16 well done for tricking me into giving it another shot ;) Though you only got bare minimum resurrection from old work, but that doesn't actually don't look that bad, not sure why I never submitted it.
wrt the others, FWIW I guess that * devhelp is kind of a lost cause short of bundling libdevhelp * geanypy as well, and I don't know feature difference, but indeed peasy is probably more current anyway * multiterm could likely be salvaged with relatively low effort?
multiterm could likely be salvaged with relatively low effort?
Just needs "somebody" to do it ;-)
@eht16 well done for tricking me into giving it another shot ;) Though you only got bare minimum resurrection from old work, but that doesn't actually don't look that bad, not sure why I never submitted it.
This wasn't completely intended by me but nice that it worked :). Thanks for pushing the old uncompletely work, if anyone wants to pick it up, now they can.
If nobody stops me, I will merge this in a week so that we finally get a green CI again.
Thanks for pushing the old uncompletely work, if anyone wants to pick it up, now they can.
If nobody stops me, I will merge this in a week so that we finally get a green CI again.
Actually if it's alright with you, I'd rather merge that PR and see how it goes. I just went over it and fixed a couple of things, and it's actually in a pretty decent shape. And if anybody want to improve what could be missing they could still do.
@b4n, "that PR"? Which PR?
Probably #1224
@eht16 pushed 2 commits.
a7c921ddfa31a0a6847d02b2bacf3698429baaa0 Remove unusable plugins: DevHelp, GeanyPy, Multiterm 819efce62614a8a16f8d27a49e057b95cce2aa4c Re-add WebHelper plugin
@b4n Alright, Webhelper is back in the game.
I would like to restart the "merge in about a week counter" to get this done.
@eht16 Fine with me, I now merged the webhelper part, so at least I got the ball moving again (and I think it's in a fair enough state anyway).
BTW I just gave a quick look at multiterm, and it's less trivial than I expected, so it'd require somebody actually motivated to do it.
Merged #1217 into master.
github-comments@lists.geany.org