I removed the GeanyFunctions *geany_functions declaration and bumped the API for the plugins where the change was trivial. I skipped:
* geanylua (wasn't quite sure if geany_functions isn't exported to lua scripts) * geanypy (like above) * multiterm (written in vala and I didn't want to screw things up)
(Mostly) fixes https://github.com/geany/geany-plugins/issues/382 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/388
-- Commit Summary --
* Remove deprecated GeanyFunctions *geany_functions * Bump required plugin API to 224 because of removed geany_functions
-- File Changes --
M autoclose/src/autoclose.c (3) M automark/src/automark.c (3) M codenav/src/codenavigation.c (3) M codenav/src/codenavigation.h (2) M commander/src/commander-plugin.c (3) M debugger/src/breakpoints.c (1) M debugger/src/btnpanel.c (1) M debugger/src/callbacks.c (1) M debugger/src/dbm_gdb.c (1) M debugger/src/debug.c (1) M debugger/src/dpaned.c (1) M debugger/src/envtree.c (1) M debugger/src/keys.c (1) M debugger/src/markers.c (1) M debugger/src/plugin.c (3) M debugger/src/tabs.c (1) M debugger/src/tpage.c (1) M debugger/src/utils.c (1) M defineformat/src/defineformat.c (3) M devhelp/src/dhp-plugin.c (3) M devhelp/src/dhp-plugin.h (1) M geanydoc/src/config.c (1) M geanydoc/src/geanydoc.c (3) M geanyextrasel/src/extrasel.c (3) M geanygendoc/src/ggd-plugin.c (3) M geanygendoc/src/ggd-plugin.h (1) M geanyinsertnum/src/insertnum.c (3) M geanylatex/src/geanylatex.c (3) M geanylatex/src/geanylatex.h (1) M geanylipsum/src/geanylipsum.c (3) M geanymacro/src/geanymacro.c (3) M geanyminiscript/src/gms.c (3) M geanyminiscript/src/gms.h (1) M geanynumberedbookmarks/src/geanynumberedbookmarks.c (3) M geanypg/src/geanypg.c (3) M geanypg/src/geanypg.h (1) M geanyprj/src/geanyprj.c (3) M geanyprj/src/geanyprj.h (1) M geanyprj/src/unittests.c (3) M geanysendmail/src/geanysendmail.c (3) M geanyvc/src/externdiff.c (2) M geanyvc/src/geanyvc.c (3) M geanyvc/src/utils.c (1) M geniuspaste/src/geniuspaste.c (3) M git-changebar/src/gcb-plugin.c (3) M markdown/src/plugin.c (3) M overview/overview/overviewplugin.c (8) M overview/overview/overviewplugin.h (1) M pairtaghighlighter/src/pair_tag_highlighter.c (3) M pohelper/src/gph-plugin.c (3) M pretty-printer/src/PluginEntry.c (3) M shiftcolumn/src/shiftcolumn.c (4) M tableconvert/src/tableconvert.c (3) M tableconvert/src/tableconvert.h (1) M treebrowser/src/treebrowser.c (3) M updatechecker/src/updatechecker.c (3) M webhelper/src/gwh-plugin.c (3) M webhelper/src/gwh-plugin.h (1) M xmlsnippets/src/plugin.c (3) M xmlsnippets/src/plugin.h (1)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/388.patch https://github.com/geany/geany-plugins/pull/388.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388
LGBI
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388#issuecomment-193223336
Merged #388.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388#event-582118865
@@ -42,7 +42,6 @@
/* Last */ #include "plugindata.h" /* this defines the plugin API */ -#include "geanyfunctions.h" /* this wraps geany_functions function pointers */
leads to missing declaration of `utils_str_equal()` #396
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388/files#r55527445
@@ -35,7 +35,6 @@ #include "document.h" #include "keybindings.h" #include "plugindata.h" -#include "geanyfunctions.h"
same, with several other functions
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388/files#r55527488
@@ -42,7 +42,6 @@
/* Last */ #include "plugindata.h" /* this defines the plugin API */ -#include "geanyfunctions.h" /* this wraps geany_functions function pointers */
Should change the code to use `g_strcmp0` or `strcmp` instead of using the plugin API as a redundant utility library :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388/files#r55534609
@@ -42,7 +42,6 @@
/* Last */ #include "plugindata.h" /* this defines the plugin API */ -#include "geanyfunctions.h" /* this wraps geany_functions function pointers */
yeah that probably would be better, esp. as it's misused :)
We may want to deprecated `utils_str_equal()` in favor to this at the same time.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/388/files#r55568390
github-comments@lists.geany.org