You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2345
-- Commit Summary --
* sidebar.c: Replace CHANGE_TREE macro with function
-- File Changes --
M src/sidebar.c (37)
-- Patch Links --
https://github.com/geany/geany/pull/2345.patch https://github.com/geany/geany/pull/2345.diff
Looks like a nice cleanup.
Kind of pedantic but using the adjective "unhygienic" relating to C macros is superfluous since they all are :)
@codebrainz true, but I think what @ntrel is saying is that this one is _actually_ capturing variables with the attendant risks.
kugel- commented on this pull request.
@@ -232,21 +232,18 @@ void sidebar_update_tag_list(GeanyDocument *doc, gboolean update)
gtk_widget_show(doc->priv->tag_tree); g_object_ref((gpointer)doc->priv->tag_tree); /* to hold it after removing */ } - doc->has_tags = symbols_recreate_tag_list(doc, SYMBOLS_SORT_USE_PREVIOUS); doc->priv->tag_tree_dirty = FALSE; }
if (doc->has_tags) {
Can safely remove the curly braces now.
Small nitpick, not a blocker. Nice change.
kugel- approved this pull request.
github-comments@lists.geany.org