When tabbing through the interface to change the currently focused widget, one gets stuck when reaching the overview.
Steps to reproduce: 1. Enable Overview plugin 2. Get keyboard focus to the message window (e.g. click on one of the status lines) 3. hit <kbd>Shift+Tab</kbd> twice: first one will reach the msgwindow's tab itself (e.g. "Status"), second will reach overview
At this point, it's not possible to move anymore using <kbd>Tab</kbd> or <kbd>Shift+Tab</kbd>. I don't believe this is on purpose, or has any usefulness as the overview isn't editable.
Proposed fix: mark the overview itself as not focusable (`gtk_widget_set_can_focus(self, FALSE)`) so it's skipped over. Alternatively, if you want to e.g. allow arrows to move in the overview, make sure to left focus cycling through.
Could this have any relation to #730 and grabbing keys?
@elextr I noticed it while trying to reproduce #730, but although it looks similar, I'm not quite sure it's actually related. But yeah, maybe it could be a different symptom of the same thing: getting keyboard focus on the overview.
@b4n They could be related if produce, for example, almost same warning, i guess.
I don't get any warnings myself
@b4n it only needs to accept mouse clicks and scroll wheel. I don't know if that requires having focus.
@codebrainz It doesn't. This seems not to break anything: ```diff diff --git a/overview/overview/overviewscintilla.c b/overview/overview/overviewscintilla.c index 41840638..40e46fc8 100644 --- a/overview/overview/overviewscintilla.c +++ b/overview/overview/overviewscintilla.c @@ -691,6 +691,8 @@ overview_scintilla_init (OverviewScintilla *self) memcpy (&self->overlay_color, &def_overlay_color, sizeof (OverviewColor)); memcpy (&self->overlay_outline_color, &def_overlay_outline_color, sizeof (OverviewColor));
+ gtk_widget_set_can_focus (GTK_WIDGET (self), FALSE); + gtk_widget_add_events (GTK_WIDGET (self), GDK_EXPOSURE_MASK | GDK_FOCUS_CHANGE_MASK | ```
FWIW, without this, if you focus the overview you can get funny behavior, like <kbd>Ctrl+A</kbd> that will select everything in the overview :)
@b4n cool. Feel free to merge this if you want, else I'll do it eventually.
github-comments@lists.geany.org