Would be nice to show "Match m of N" in the status bar when searching strings.
It could also add "in the current document/session/selection"
Geany already says `Found 3 matches for "foo"` for any "find all" requests. It doesn't make sense to show it for next or previous, it will always be a single match.
Apart from my growing old-timers disease I don't see the point of reminding me that I selected `mark`, `session` or `document` (and find doesn't do selection).
I didn't speak about "find all" requests. Also "find all" requests open a Message Window. I was talking about a one-by-one next/previous search. Of course it will be a single match, but it will: 1. tell you where you are in search results, without the need to open up the message window 2. eliminate the problem of unnoticed wrapped search (with "Always wrap search" option enabled) Check out how it works in other editors or even in your browser.
This is not an existing capability
As I said it doesn't make sense to show `Found 1 matches of "foo"` when finding the next/previous and Geany already shows such a message for find alls.
Browsers automatically do a progressive find all, they don't wait for you to type the search pattern then return the first result so their behaviour is irrelevant.
If find didn't find anything, the background of the search pattern changes colour to indicate that.
Showing in the status bar that the search wrapped might be a good idea though, you could raise a separate feature request for that and somebody may contribute it. Personally I just notice that the line numbers have reduced.
There's no reason this couldn't be added if someone wanted to create a clean pull request and prove that it won't have a negative performance impact, even on huge documents.
Browsers automatically do a progressive find all, they don't wait for you to type the search pattern then return the first result so their behaviour is irrelevant.
I assume the OP is wanting Geany to behave more like browsers/other editors, so it's not really irrelevant.
A couple examples:
I assume the OP is wanting Geany to behave more like browsers/other editors, so it's not really irrelevant.
Then the OP should say that, and if you want it you should say that, and not try to blame the OP.
And sure totally redesigning how search works will be fine, pull requests are welcome.
Then the OP should say that
Perhaps the OP didn't articulate it well, but it's implied if you want to know the current match and how many total matches, that you have to search the whole document first to know those values.
And sure totally redesigning how search works will be fine
Might not be a huge change, most of the code already exists to search/mark the whole document and to do incremental matches.
Might not be a huge change, most of the code already exists to search/mark the whole document and to do incremental matches.
Possibly, but its not going to be trivial. I actually wasn't being sarcastic about redesigning it, I _know_ how browsers work, (you didn't need to provide an example :) and I often find it useful. But I don't see how it will work with regexen, running a partial regex simply isn't useful, so both approaches will need to exist.
I also find the marking of matches in the scroll bar to be useful (on Chrome, it doesn't seem to happen on your Tiredfox image above).
Also some thought about how it works with replace, or does that stay as it is?
As I said pull requests or maybe design suggestions first are welcome, but whilst I am interested and will likely find it useful, I won't work on it myself.
I would also find this feature useful. I came from another text editor that had this and I miss it in Geany.
My use-case is that I hit Ctrl-f to bring up the Find dialog, then type a word and hit Enter continuously to iterate through the matches in the document. I don't use/need the Message window.
Currently as I hit Enter to iterate through the matches, I don't know where I am. Is the current highlighted word one of only a few matches, or one of hundreds? Even if I know how many matches there are in total (using the Find All > Mark button), I still don't know whether the current highlighted word is at the beginning, end or middle of that group of matches.
Instead, it'd be nice if the current and total matches were displayed in the statusbar. E.g. `2/5 matches`, `4/5 matches`, `1/5 matches (search wrapped)`. That way, as I iterate through the matches I know exactly where I am, how many matches there are remaining before the end of the document, etc.
Then contribute it, Geany is a totally volunteer project, and the fact that nobody has done anything since 2019 indicates that its either difficult to do, or do well, or nobody feels its more important to them than many other things they want to do.
github-comments@lists.geany.org