Also remove NaN as it is just a property of floating-point types, it's not a reserved word: https://github.com/JetBrains/kotlin/blob/30788566012c571aa1d3590912468d1ebe5... You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3456
-- Commit Summary --
* [filetypes] Update Kotlin basic types
-- File Changes --
M data/filedefs/filetypes.Kotlin.conf (2)
-- Patch Links --
https://github.com/geany/geany/pull/3456.patch https://github.com/geany/geany/pull/3456.diff
@dolik-rce commented on this pull request.
@@ -4,7 +4,7 @@
# https://kotlinlang.org/docs/reference/keyword-reference.html primary=abstract assert break case catch class const continue default do else enum extends final finally for goto if implements import instanceof interface native new package private protected public return static strictfp super switch synchronized this throw throws transient try volatile while true false null as fun in object typealias val var when by constructor delegate dynamic field file get init param property receiver set setparam where actual annotation companion const crossinline data expect external infix inline inner internal lateinit noinline open operator out reified sealed suspend tailrec vararg field it # https://kotlinlang.org/docs/reference/basic-types.html -secondary=Double Float Long Int Short Byte NaN Void +secondary=Boolean Byte Char Double Float Long Int Short String UByte UInt ULong UShort Void
I'd maybe ditch `Void` too, it's only used in Java IIRC.
What about `Nothing` and `Unit`? Those are kind of basic types too, aren't they? But the link above doesn't mention them, so it is kind of gray area.
Otherwise it looks fine to me (as a Kotlin user).
@ntrel pushed 1 commit.
9c146b912b3b98d2123dd65c071d0aa54704cc5d Add Any, Nothing, Unit; Remove Void
@ntrel commented on this pull request.
@@ -4,7 +4,7 @@
# https://kotlinlang.org/docs/reference/keyword-reference.html primary=abstract assert break case catch class const continue default do else enum extends final finally for goto if implements import instanceof interface native new package private protected public return static strictfp super switch synchronized this throw throws transient try volatile while true false null as fun in object typealias val var when by constructor delegate dynamic field file get init param property receiver set setparam where actual annotation companion const crossinline data expect external infix inline inner internal lateinit noinline open operator out reified sealed suspend tailrec vararg field it # https://kotlinlang.org/docs/reference/basic-types.html -secondary=Double Float Long Int Short Byte NaN Void +secondary=Boolean Byte Char Double Float Long Int Short String UByte UInt ULong UShort Void
Thanks, now done. Also added `Any`.
@dolik-rce fine by you? If so, let's merge.
Yes, you can merge it. Thanks.
Merged #3456 into master.
github-comments@lists.geany.org