This removes the dependency/the requirement for GLib version 2.46. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/719
-- Commit Summary --
* workbench: use simple/old file monitor events only
-- File Changes --
M workbench/src/plugin_main.c (2) M workbench/src/wb_monitor.c (22) M workbench/src/wb_monitor.h (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/719.patch https://github.com/geany/geany-plugins/pull/719.diff
codebrainz commented on this pull request.
@@ -22,7 +22,7 @@
#include <glib.h> #include "wb_project.h"
-#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO)
I don't think you need this `HAVE_GIO` stuff from the build system as GIO is part of GLib, Geany requires GIO already, and AFAIK some plugins too.
elextr commented on this pull request.
@@ -22,7 +22,7 @@
#include <glib.h> #include "wb_project.h"
-#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO)
Yes, Geany itself stopped checking back in [2011](https://github.com/geany/geany/commit/591417697010200441af6b6ed76ef28ef4731d...)
LarsGit223 commented on this pull request.
@@ -22,7 +22,7 @@
#include <glib.h> #include "wb_project.h"
-#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO)
Yes, geany itself is not using it, I will remove it. Maybe it should be removed from other plugins also.
@LarsGit223 pushed 1 commit.
87a6400 workbench: removed compile-time checks
LarsGit223 commented on this pull request.
@@ -22,7 +22,7 @@
#include <glib.h> #include "wb_project.h"
-#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO)
Done.
@LarsGit223 pushed 1 commit.
e171c35 workbench: cleaned up 'workbench.m4'
Merged #719.
github-comments@lists.geany.org