You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-themes/pull/62
-- Commit Summary --
* Add new themes via upload * Add new screenshot for theme via upload * Add files via upload
-- File Changes --
A colorschemes/dark-abc.conf (107) A colorschemes/light-abc.conf (114) A screenshots/dark-abc.png (0) A screenshots/light-abc.png (0)
-- Patch Links --
https://github.com/geany/geany-themes/pull/62.patch https://github.com/geany/geany-themes/pull/62.diff
@inonehp pushed 1 commit.
b2c202d8765f1904e9709c0f2d9d1af12adbda71 Update theme
Closed #62.
Reopened #62.
@inonehp pushed 1 commit.
2a0cb1a3c040c37302e9a5586e0475adc6f4e82b Add files via upload
@inonehp pushed 1 commit.
99e94ddf0934c376ef38b345b4121fc47afdca26 Add Theme | update
@inonehp pushed 1 commit.
d4014bfedde5da64ed82a217a8327b3da4870d03 Add theme update via upload
@inonehp pushed 1 commit.
6847d284c91f3858a9a491761a76a477bc575812 Updated the author name.
@eht16 requested changes on this pull request.
Could you please add your themes to the `AUTHORS` file?
@@ -0,0 +1,108 @@
+#
Would you mind adding a full file header with license and copyright information? Like this one: https://github.com/geany/geany-themes/blob/master/colorschemes/github.conf
@@ -0,0 +1,108 @@
+# +# GNU General Public License +# +#https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0... +# Inspired by Github, Sublime Text, Geany + + + +[theme_info] +name=Dark Abc
The other themes with light/dark variants mostly use a naming scheme like "<name>-light" and "<name>-dark".
What do you think about following this scheme and rename your themes to "abc-light" and "abc-dark"?
(then also please rename the files and screenshots)
@inonehp pushed 1 commit.
ee93c74d6f85e619724f42c272faac00cc6bd90b Update Abc theme name
@inonehp pushed 1 commit.
1978a77b9358bd7b6feba35a0e5187100499eb36 Add files via upload
@inonehp pushed 1 commit.
649f91ba6f2114fba7d60d5ae1b1203808a394da Update AUTHORS
@inonehp commented on this pull request.
@@ -0,0 +1,108 @@
+# +# GNU General Public License +# +#https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0... +# Inspired by Github, Sublime Text, Geany + + + +[theme_info] +name=Dark Abc
Sorry, I didn't rename it, I uploaded it with the new name and deleted it with the old name
@inonehp commented on this pull request.
@@ -0,0 +1,108 @@
+#
I tried to add a theme in AUTHORS. I tried to update the license. Thank you.
@inonehp pushed 1 commit.
399abb4f8d1127b93528ad066393db15708e8953 Delete colorschemes/light-abc.conf
@inonehp pushed 1 commit.
587b459c0b440c54ae67ab74e0792c2b993223d2 Delete colorschemes/dark-abc.conf
@inonehp pushed 1 commit.
e34a8269bd9bc2f36c320316a029f2582b3af2bd Delete screenshots/light-abc.png
@inonehp pushed 1 commit.
abeb3d66ddc0203165410af2515e47ecdb804db8 Delete screenshots/dark-abc.png
@inonehp Thanks for the changes, to me it looks good now. If you are fine it with, I would like to merge this so it is ready to use for the upcoming Geany 2.0 release.
@eht16 approved this pull request.
@eht16 Okay, thanks.
Merged #62 into master.
github-comments@lists.geany.org