This should fix #617
(Internationalization must be done) You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/894
-- Commit Summary --
* Added option to print all text black on white background. Internationalization must be done.
-- File Changes --
M data/geany.glade (18) M src/keyfile.c (2) M src/prefs.c (6) M src/printing.c (14) M src/printing.h (1)
-- Patch Links --
https://github.com/geany/geany/pull/894.patch https://github.com/geany/geany/pull/894.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/894
Interesting. Quick comments:
* Should probably use Stash module for pref * Should propose other modes too (*normal*/*inverted light, white background*/*black on white*/*color on white*/*color on white (but line numbers)*), using a combo box I guess
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/894#issuecomment-177628930
LGTM by inspection.
@b4n, don't agree about stash if all other printing stuff does not use it, having one option different is confusing. Make an issue for the other modes if you want them, but who cares about printing, this fixes the main gripe we get.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/894#issuecomment-177660713
@elextr about other modes, well… my main reason is that
1. it's super easy to support, as there would be a setting anyway, and allows for some other useful modes (like *normal*) 2. not adding it right now means there will be a setting to migrate from in the future if additional modes are implemented.
I can do this is you want, should take like 10 minutes or so
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/894#issuecomment-177660926
(I've got a version with color mode option, I'll get it sorted tomorrow. It's larger and I did a lot more cleanup work -- yet it's still not perfect --, but it's not so bad)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/894#issuecomment-177717825
Any chance of merging this in ? Printing is still a main PITA when using any dark color scheme.
github-comments@lists.geany.org