The first commit combines the existing two macros. The second commit replaces the new macro with the array code. It might help to check the individual commits when reviewing.
Draft as it needs testing. Perhaps commits like this should target an unstable build branch? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2301
-- Commit Summary --
* build.c: Replace return_cmd_if macros with simpler BREAK_IF_CMD macro * Replace unhygienic macro calls with array of struct
-- File Changes --
M src/build.c (115)
-- Patch Links --
https://github.com/geany/geany/pull/2301.patch https://github.com/geany/geany/pull/2301.diff
Tangential to this PR, all C/C++ macros are unhygienic :smiley:
@ntrel pushed 1 commit.
7ec1ff0372fa598c49305ce8114c81765b96f040 Replace non-standard C `= {}` with `= {0}` and remove trailing commas
Perhaps commits like this should target an unstable build branch?
I would certainly agree thats a good workflow normally, it would allow us to be less exacting about things being committed. But Geany has so few contributors I'm not sure that we can test a stable master and an unstable branch very well.
github-comments@lists.geany.org