Update the GPL note template with the latest version found on gnu.org. It includes the transition from GPLv2 to GPLv3, and refers to a website instead of a postal address for the text of the GNU GPL. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3549
-- Commit Summary --
* Update GPL note template
-- File Changes --
M data/templates/gpl (11)
-- Patch Links --
https://github.com/geany/geany/pull/3549.patch https://github.com/geany/geany/pull/3549.diff
Closed #3549.
The GPL 2 license of a piece of software cannot be changed without permission of every contributor under the original license. You would need to provide evidence of that permission before this can be changed.
Reopened #3549.
Oooops misread, you only want to change a template, not the license, that can certainly be discussed. Perhaps would be better to make separate GPL2 and GPL3 templates since much existing software is GPL2 and headers for new files there should likely be the same as the rest of the project, whilst new projects should probably be GPL3.
@alberic89 pushed 1 commit.
c929e86d55fa4cd40dd7586b116e9b26cc82760a Revert "Update GPL note template"
@alberic89 pushed 3 commits.
48f5815c65db0d4a5a8fb1b3da9a81fd16c44267 Add GPLv3 notice and header insertion fonctions and menu item 35524676dee7acf37d27245acc532fb467f6af0e regenerate .po files 588a0f007c7e8869348e54d221706a61314db753 Merge branch 'gpl3-notice' into patch-1
I have done some little changes, and now you can choose between gplv2 and v3 for license note and header.  But I am not very familiar with C/C++ and the Geany codebase, and I have possibly made some big mistakes or horrible things. And I have not choose new shortcuts for the menu items, I prefer let this to the translators.
@alberic89 commented on this pull request.
@@ -168,7 +171,7 @@ void templates_replace_common(GString *tmpl, const gchar *fname,
NULL); }
- +// Maybe a fix to do in this function
I don't know for what this function is useful, but I see it use get_template_fileheader function. It needs maybe some changes for including gplv3 file header ?
@alberic89 commented on this pull request.
@@ -501,6 +524,18 @@ gchar *templates_get_template_fileheader(gint filetype_idx, const gchar *fname)
return g_string_free(template, FALSE); }
+// The line `GEANY_API_SYMBOL` is needeed ?
The function templates_get_template_fileheader had a line with GEANY_API_SYMBOL just before the function definition, I don't know exactly what it does, but it maybe needed also for the function below.
@eht16 requested changes on this pull request.
On po/ar.po:
Please remove all the translation changes in the *.po files. These are not necessary in the pull request. The translation files will be updated later as part of the release process.
@@ -168,7 +171,7 @@ void templates_replace_common(GString *tmpl, const gchar *fname,
NULL); }
- +// Maybe a fix to do in this function
It replaces the `{fileheader}` placeholder in other templates when they are loaded. As noted below, I think we don't need the "fileheader3" variant at all.
@@ -501,6 +524,18 @@ gchar *templates_get_template_fileheader(gint filetype_idx, const gchar *fname)
return g_string_free(template, FALSE); }
+// The line `GEANY_API_SYMBOL` is needeed ?
Yes, it would be necessary here as well. This helps the linker to make the function available for the plugin API.
BUT: I think we don't need the "fileheader3" template at all. It doesn't add much value as it is the same as "fileheader" but only for GPLv3. Since the templates are fully user customizable, it is probably enough for users to modify the existing "fileheader" template or add a new one themselves.
So I suggest to remove the "fileheader3" template altogether.
@alberic89 pushed 1 commit.
d8912aca788ef9fe9759bd3e09c33bf0a926aac3 Revert "regenerate .po files"
@alberic89 pushed 1 commit.
431790c1750f915f21585ea1823cf5d97b0b487c Delete fileheader3
I had removed all reference to fileheader3 and the po files, as you had asked.
github-comments@lists.geany.org