See #768. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/769
-- Commit Summary --
* Drop Waf build system support
-- File Changes --
M .gitignore (7) M HACKING (9) M Makefile.am (2) M doc/geany.txt (67) M doc/making-a-release (2) M geany.spec.in (7) D scripts/wafinit.sh (72) D waf (0) D wscript (981)
-- Patch Links --
https://github.com/geany/geany/pull/769.patch https://github.com/geany/geany/pull/769.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/769
@@ -171,9 +171,9 @@ Geany requires GTK >= 2.24 and GLib >= 2.28. API symbols from newer GTK/GLib versions should be avoided or made optional to keep the source code building on older systems.
-It is recommended to use the 2.24 API documentation of the GTK -libs (including GLib, GDK and Pango) has the advantages -that you don't get confused by any newer API additions and you +It is recommended to use the 2.24 API documentation of the GTK +libs (including GLib, GDK and Pango) has the advantages +that you don't get confused by any newer API additions and you
While it’s good to remove trailing white spaces, it should probably not be in this commit.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/769/files#r45583419
@@ -171,9 +171,9 @@ Geany requires GTK >= 2.24 and GLib >= 2.28. API symbols from newer GTK/GLib versions should be avoided or made optional to keep the source code building on older systems.
-It is recommended to use the 2.24 API documentation of the GTK -libs (including GLib, GDK and Pango) has the advantages -that you don't get confused by any newer API additions and you +It is recommended to use the 2.24 API documentation of the GTK +libs (including GLib, GDK and Pango) has the advantages +that you don't get confused by any newer API additions and you
I agree in general. In this case it is probably just not worth to make an extra commit for this.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/769/files#r45666906
@@ -60,13 +60,6 @@ Requires: pkgconfig gtk2-devel This package contains the header files and pkg-config file needed for building Geany plug-ins. You do not need to install this package to use Geany.
-%prep -%setup -q
should these 2 lines really be removed?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/769/files#r45674782
@@ -60,13 +60,6 @@ Requires: pkgconfig gtk2-devel This package contains the header files and pkg-config file needed for building Geany plug-ins. You do not need to install this package to use Geany.
-%prep -%setup -q
Oops, no. I re-added the missing lines. Will squash the commits before merging.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/769/files#r46091826
Merged #769.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/769#event-587784490
github-comments@lists.geany.org