@eht16 commented on this pull request.


In src/callbacks.c:

> @@ -634,7 +634,11 @@ gboolean toolbar_popup_menu(GtkWidget *widget, GdkEventButton *event, gpointer u
 {
 	if (event->button == 3)
 	{
+#if GTK_CHECK_VERSION(3,22,0)

The GTK version check and popup menu commands repeat quite often and look very similar.

Could we maybe put them into a helper function, maybe ui_menu_poopup() in "ui_utils.c" or so, to not have to repeat this everywhere?
Also we could add a sentence or two to document what happens there.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3011/review/1078288901@github.com>