@LarsGit223 commented on this pull request.


In addons/src/ao_colortip.c:

> +static void connect_documents_button_press_signal_handler(AoColorTip *colortip)
+{
+	guint i = 0;
+	/* connect the button-press event for all open documents */
+	foreach_document(i)
+	{
+		connect_document_button_press_signal_handler(colortip, documents[i]);
+	}
+}
+
+
+static void ao_color_tip_finalize(GObject *object)
+{
+	g_return_if_fail(object != NULL);
+	g_return_if_fail(IS_AO_COLORTIP(object));
+

I wonder if I should throw away the whole GObject stuff and pass the config values directly from the ao_info struct in addons.c. I only used it because I saw it in ao_markword.c. I think it's quite complicated stuff for just saving to values. Is there any reason for not removing it?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.