@techee commented on this pull request.


In src/symbols.c:

>  {
+	GeanyDocument *doc = document_get_current();
+
+	if (plugin_extension_goto_provided(doc, NULL))
+		return plugin_extension_goto_perform(doc, pos, definition);

So what should I do here? The options I see are:

  1. Make the function non-static in keybindings.c and export it (but it has nothing to do with keybindings so not good API-wise)
  2. Move it to say editor.c and make keybindings.c and symbols.c use it from there (makes more sense API-wise)
  3. Make another copy of it in symbols.c
  4. Keep the code as it is and not to use the selection mode


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2113244502@github.com>